saymrwulf/pytorch
1
0
Fork 0
mirror of https://github.com/saymrwulf/pytorch.git synced 2026-05-14 20:57:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Small fixes in Dependency.cmake and run_test.py (#44414)

Browse source 
Summary:
Do not add gencode flags to NVCC_FLAGS twice: First time they are added in `cmake/public/cuda.cmake` no need to do it again in `cmake/Dependencies.cmake`
Copy `additional_unittest_args` before appending local options to it in `run_test()` method

Pull Request resolved: https://github.com/pytorch/pytorch/pull/44414

Reviewed By: seemethere

Differential Revision: D23605733

Pulled By: malfet

fbshipit-source-id: 782a0da61650356a978a892fb03c66cb1a1ea26b
This commit is contained in:
Nikita Shulga 2020-09-09 15:07:27 -07:00 committed by Facebook GitHub Bot
parent b0bcdbb1ab
commit fc51047af5
2 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
cmake/Dependencies.cmake
View file

@ -1501,7 +1501,6 @@ if(NOT INTERN_BUILD_MOBILE)
endif()
list(APPEND CUDA_NVCC_FLAGS ${TORCH_NVCC_FLAGS})
list(APPEND CUDA_NVCC_FLAGS ${NVCC_FLAGS_EXTRA})
if(CMAKE_POSITION_INDEPENDENT_CODE AND NOT MSVC)
list(APPEND CUDA_NVCC_FLAGS "-Xcompiler" "-fPIC")
endif()

2
test/run_test.py
View file

@ -217,7 +217,7 @@ def get_executable_command(options, allow_pytest):
def run_test(test_module, test_directory, options, launcher_cmd=None, extra_unittest_args=None):
unittest_args = options.additional_unittest_args
unittest_args = options.additional_unittest_args.copy()
if options.verbose:
unittest_args.append('--verbose')
if test_module in RUN_PARALLEL_BLOCKLIST: