From f91b19c2aaa615e4de90c9b96ec45371eb412a73 Mon Sep 17 00:00:00 2001 From: Hong Xu Date: Thu, 25 Jul 2019 07:08:23 -0700 Subject: [PATCH] Do not explicitly set USE_FBGEMM in tools/setup_helpers/cmake.py (#23314) Summary: Instead, defer its default value to CMakeLists.txt NO_FBGEMM has already been handled in tools/setup_helpers/env.py (although deprecated) Pull Request resolved: https://github.com/pytorch/pytorch/pull/23314 Differential Revision: D16493580 Pulled By: ezyang fbshipit-source-id: 7255eb1df5e8a6dd0362507d68da0986a9ed46e2 --- CMakeLists.txt | 2 +- tools/setup_helpers/cmake.py | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 65f0f2a8321..e8f4352223e 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -101,7 +101,7 @@ option(CAFFE2_STATIC_LINK_CUDA "Statically link CUDA libraries" OFF) cmake_dependent_option( USE_CUDNN "Use cuDNN" ON "USE_CUDA" OFF) -option(USE_FBGEMM "Use FBGEMM (quantized 8-bit server operators)" OFF) +option(USE_FBGEMM "Use FBGEMM (quantized 8-bit server operators)" ON) option(USE_FFMPEG "Use ffmpeg" OFF) option(USE_GFLAGS "Use GFLAGS" OFF) option(USE_GLOG "Use GLOG" OFF) diff --git a/tools/setup_helpers/cmake.py b/tools/setup_helpers/cmake.py index 031c893f108..9ef63537468 100644 --- a/tools/setup_helpers/cmake.py +++ b/tools/setup_helpers/cmake.py @@ -260,8 +260,6 @@ class CMake: 'BUILD_TEST': build_test, 'USE_CUDA': USE_CUDA, 'USE_DISTRIBUTED': USE_DISTRIBUTED, - 'USE_FBGEMM': not (check_env_flag('NO_FBGEMM') or - check_negative_env_flag('USE_FBGEMM')), 'USE_NUMPY': USE_NUMPY, 'USE_SYSTEM_EIGEN_INSTALL': 'OFF' })