From b349d159077bc2c4207c9a97f889dc2c572f6928 Mon Sep 17 00:00:00 2001 From: Michael Suo Date: Tue, 5 Jul 2022 16:52:17 -0700 Subject: [PATCH] [build] fix compiling with clang13 (#80916) This check is incorrect; clang 13.1.0 doesn't exist. Pull Request resolved: https://github.com/pytorch/pytorch/pull/80916 Approved by: https://github.com/malfet --- cmake/Dependencies.cmake | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cmake/Dependencies.cmake b/cmake/Dependencies.cmake index 368299edeb2..1c65ed87ed2 100644 --- a/cmake/Dependencies.cmake +++ b/cmake/Dependencies.cmake @@ -824,7 +824,8 @@ if(USE_FBGEMM) if("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang" AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 13.0.0) # See https://github.com/pytorch/pytorch/issues/74352 target_compile_options(asmjit PRIVATE -Wno-deprecated-copy) - if(CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 13.1.0) + if(("${CMAKE_CXX_COMPILER_ID}" STREQUAL "AppleClang" AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 13.1.6) + OR("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang" AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 13.0.0)) # -Wno-unused-but-set-variable doesn't exist in Apple clang version 13.0.0 (clang-1300.0.29.30) target_compile_options(asmjit PRIVATE -Wno-unused-but-set-variable) endif()