saymrwulf/pytorch
1
0
Fork 0
mirror of https://github.com/saymrwulf/pytorch.git synced 2026-05-14 20:57:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

[codemod] Remove unused variables in caffe2/caffe2/video/video_decoder.cc (#122151)

Browse source 
Summary:
LLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.

This diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code.

 - If you approve of this diff, please use the "Accept & Ship" button :-)

Test Plan: Sandcastle

Differential Revision: D54378401

Pull Request resolved: https://github.com/pytorch/pytorch/pull/122151
Approved by: https://github.com/Skylion007
This commit is contained in:
Richard Barnes 2024-03-19 22:34:14 +00:00 committed by PyTorch MergeBot
parent a80c60ad8f
commit a6aa3afa77
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
caffe2/video/video_decoder.cc
View file

@ -436,7 +436,6 @@ void VideoDecoder::decodeLoop(
// transport and getting decoded frames back.
// Therefore, after EOF, continue going while
// the decoder is still giving us frames.
int ipacket = 0;
while ((!eof || gotPicture) &&
/* either you must decode all frames or decode up to maxFrames
* based on status of the mustDecodeAll flag */
@ -463,7 +462,6 @@ void VideoDecoder::decodeLoop(
LOG(ERROR) << "Error reading packet : " << ffmpegErrorStr(ret);
return;
}
ipacket++;
auto si = packet.stream_index;
if (params.getAudio_ && audioStreamIndex_ >= 0 &&