saymrwulf/pytorch
1
0
Fork 0
mirror of https://github.com/saymrwulf/pytorch.git synced 2026-05-14 20:57:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix toIValue dict iteration (#26856)

Browse source 
Summary:
It's not clear why, but using the `[]` accessory in pybind was causing an error (for something I ran into while scripting MaskR-CNN)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/26856

Pulled By: driazati

Differential Revision: D17589635

fbshipit-source-id: 142a9b4e30bcf2b65f1ba03c2d6775f2baff43f5
This commit is contained in:
davidriazati 2019-09-30 16:32:08 -07:00 committed by Facebook Github Bot
parent fb8fd6dc73
commit 5e7549c3b5
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
torch/csrc/jit/pybind_utils.h
View file

@ -321,14 +321,14 @@ inline IValue createGenericList(py::handle obj, const TypePtr& elem_type) {
}
inline IValue createGenericDict(
py::handle obj,
py::dict obj,
const TypePtr& key_type,
const TypePtr& value_type) {
c10::impl::GenericDict elems(key_type, value_type);
elems.reserve(py::len(obj));
for (auto key : obj) {
for (auto entry : obj) {
elems.insert(
toIValue(key, key_type), toIValue(obj[key], value_type));
toIValue(entry.first, key_type), toIValue(entry.second, value_type));
}
return IValue(std::move(elems));
}
@ -445,7 +445,7 @@ inline IValue toIValue(
case TypeKind::DictType: {
const auto& dict_type = type->expect<DictType>();
return createGenericDict(
obj, dict_type->getKeyType(), dict_type->getValueType());
py::cast<py::dict>(obj), dict_type->getKeyType(), dict_type->getValueType());
}
case TypeKind::OptionalType: {
// check if it's a none obj since optional accepts NoneType