saymrwulf/pytorch
1
0
Fork 0
mirror of https://github.com/saymrwulf/pytorch.git synced 2026-05-14 20:57:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

aten/buck | Appropriately convert clang => msvc compiler_flags. (#137944)

Browse source 
Summary:
fPIC is not available in clang on Windows - filter it out.
Also configure the flags appropriately for MSVC.

Reviewed By: rameshviswanathan

Differential Revision: D64365660

Pull Request resolved: https://github.com/pytorch/pytorch/pull/137944
Approved by: https://github.com/mwdavis84, https://github.com/ChristianK275, https://github.com/boguscoder
This commit is contained in:
Nikita Lutsenko 2024-10-15 20:21:01 +00:00 committed by PyTorch MergeBot
parent 487873f7ca
commit 370d66d7dd
1 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
buckbuild.bzl
View file

@ -5,13 +5,13 @@ load("@bazel_skylib//lib:paths.bzl", "paths")
load("//tools/build_defs:fb_native_wrapper.bzl", "fb_native")
load("//tools/build_defs:fb_xplat_cxx_library.bzl", "fb_xplat_cxx_library")
load("//tools/build_defs:fb_xplat_genrule.bzl", "fb_xplat_genrule")
load("//tools/build_defs/windows:windows_flag_map.bzl", "windows_convert_gcc_clang_flags")
load("//tools/build_defs:fbsource_utils.bzl", "is_arvr_mode")
load("//tools/build_defs:glob_defs.bzl", "subdir_glob")
load("//tools/build_defs:platform_defs.bzl", "APPLETVOS", "IOS", "MACOSX")
load("//tools/build_defs:type_defs.bzl", "is_list", "is_string")
load("//tools/build_defs/android:build_mode_defs.bzl", is_production_build_android = "is_production_build")
load("//tools/build_defs/apple:build_mode_defs.bzl", is_production_build_ios = "is_production_build")
load("//tools/build_defs/windows:windows_flag_map.bzl", "windows_convert_gcc_clang_flags")
load(
":build_variables.bzl",
"aten_cpu_source_list",
@ -213,7 +213,6 @@ _PT_COMPILER_FLAGS = [
ATEN_COMPILER_FLAGS = [
"-fexceptions",
"-frtti",
"-fPIC",
"-Os",
"-Wno-absolute-value",
"-Wno-deprecated-declarations",
@ -225,10 +224,17 @@ ATEN_COMPILER_FLAGS = [
"-Wno-unused-variable",
"-Wno-pass-failed",
"-Wno-shadow",
]
] + select({
# Not supported by clang on Windows
"DEFAULT": ["-fPIC"],
"ovr_config//compiler:clang-windows": [],
})
def get_aten_compiler_flags():
return ATEN_COMPILER_FLAGS
return select({
"DEFAULT": ATEN_COMPILER_FLAGS,
"ovr_config//compiler:cl": windows_convert_gcc_clang_flags(ATEN_COMPILER_FLAGS),
})
_COMMON_PREPROCESSOR_FLAGS = [
"-DC10_MOBILE",