saymrwulf/pytorch
1
0
Fork 0
mirror of https://github.com/saymrwulf/pytorch.git synced 2026-05-14 20:57:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

docker: Only match tags that start with v* (#120670)

Browse source 
To avoid issues where version could be confused with a ciflow tag.

Example:

```
❯ git describe --tags --always
ciflow/periodic/c3496d50f0bb437c70f27085f71155209277bfd4-47-g4ca24959d1a
❯ git describe --tags --always --match "v[1-9]*.*"
v1.8.0-rc1-36500-g4ca24959d1a
```

Resolves https://github.com/pytorch/pytorch/issues/120392

Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/120670
Approved by: https://github.com/kit1980, https://github.com/atalman
This commit is contained in:
Eli Uriegas 2024-02-26 15:49:54 -08:00 committed by PyTorch MergeBot
parent cf6df886a0
commit 27990045ff
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
docker.Makefile
View file

@ -21,7 +21,8 @@ CUDA_CHANNEL = nvidia
INSTALL_CHANNEL ?= pytorch
PYTHON_VERSION ?= 3.10
PYTORCH_VERSION ?= $(shell git describe --tags --always)
# Match versions that start with v followed by a number, to avoid matching with tags like ciflow
PYTORCH_VERSION ?= $(shell git describe --tags --always --match "v[1-9]*.*")
# Can be either official / dev
BUILD_TYPE ?= dev
BUILD_PROGRESS ?= auto