2020-03-09 17:21:58 +00:00
|
|
|
#include <gtest/gtest.h>
|
|
|
|
|
|
|
|
|
|
#include <torch/torch.h>
|
|
|
|
|
|
|
|
|
|
struct Node {};
|
|
|
|
|
|
|
|
|
|
// If `torch::autograd::Note` is leaked into the root namespace, the following compile error would throw:
|
|
|
|
|
// ```
|
|
|
|
|
// void NotLeakingSymbolsFromTorchAutogradNamespace_test_func(Node *node) {}
|
|
|
|
|
// ^
|
|
|
|
|
// error: reference to `Node` is ambiguous
|
|
|
|
|
// ```
|
|
|
|
|
void NotLeakingSymbolsFromTorchAutogradNamespace_test_func(Node *node) {}
|
|
|
|
|
|
Make PyTorch code-base clang-tidy compliant (#56892)
Summary:
This is an automatic change generated by the following script:
```
#!/usr/bin/env python3
from subprocess import check_output, check_call
import os
def get_compiled_files_list():
import json
with open("build/compile_commands.json") as f:
data = json.load(f)
files = [os.path.relpath(node['file']) for node in data]
for idx, fname in enumerate(files):
if fname.startswith('build/') and fname.endswith('.DEFAULT.cpp'):
files[idx] = fname[len('build/'):-len('.DEFAULT.cpp')]
return files
def run_clang_tidy(fname):
check_call(["python3", "tools/clang_tidy.py", "-c", "build", "-x", fname,"-s"])
changes = check_output(["git", "ls-files", "-m"])
if len(changes) == 0:
return
check_call(["git", "commit","--all", "-m", f"NOLINT stubs for {fname}"])
def main():
git_files = check_output(["git", "ls-files"]).decode("ascii").split("\n")
compiled_files = get_compiled_files_list()
for idx, fname in enumerate(git_files):
if fname not in compiled_files:
continue
if fname.startswith("caffe2/contrib/aten/"):
continue
print(f"[{idx}/{len(git_files)}] Processing {fname}")
run_clang_tidy(fname)
if __name__ == "__main__":
main()
```
Pull Request resolved: https://github.com/pytorch/pytorch/pull/56892
Reviewed By: H-Huang
Differential Revision: D27991944
Pulled By: malfet
fbshipit-source-id: 5415e1eb2c1b34319a4f03024bfaa087007d7179
2021-04-28 21:09:06 +00:00
|
|
|
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
|
2020-03-09 17:21:58 +00:00
|
|
|
TEST(NamespaceTests, NotLeakingSymbolsFromTorchAutogradNamespace) {
|
|
|
|
|
// Checks that we are not leaking symbols from the
|
|
|
|
|
// `torch::autograd` namespace to the root namespace
|
|
|
|
|
NotLeakingSymbolsFromTorchAutogradNamespace_test_func(nullptr);
|
|
|
|
|
}
|