Commit graph

163 commits

Author SHA1 Message Date
Ryan Nazareth
c95eb0dcd9 Disabling calculation of uncertainties if uncertainty.samples is not True 2019-10-07 14:17:54 -07:00
Ryan Nazareth
eb797eefaa Adapt model cv with 0 uncertainty samples and fix performance metrics 2019-10-07 14:17:54 -07:00
Jireh Tan
e8ddded4fe [BUG] Ensure regressor/seasonality names are valid; fixes #996
Ensures that `add_regressor` and `add_seasonality` are valid column names
to R, to ensure that the generated columns are then used downstream to fit
the model.

Why not put it in `validate_column_names`? Because `validate_column_names` is
also used to validate if holiday names (which can be scalar values in columns) are
valid. We want to allow `c('seans-bday', 'Xmas')` as a valid holiday input, so we
cannot then put it there.

Tested these changes by using devtools::testthat().

Resolves: #996
2019-06-25 09:39:14 -07:00
Jireh Tan
a554873a38 [BUG/TST] Add validation to prevent fourier.order <= 0; addresses #980
In reverse order of importance, this change addresses:
  - #980, by adding validation to ensure that `fourier.order` > 0
  - changes all the tests that `expect_error` using the argument
    `fourier_order`, as the argument is named `fourier.order`, so
    the intent of the test is to validate the holiday names rather
    than to check the use of the correct argument name

Resolves: #980
2019-06-21 15:27:31 -07:00
Ben Letham
7ff33137eb Change to MIT license 2019-05-21 11:40:04 -07:00
Sean J. Taylor
39e356ddbe Readying for 0.5 release 2019-05-13 23:00:12 -07:00
Ben Letham
f09ad61c26 R documentation updates 2019-05-13 15:47:28 -07:00
Ben Letham
28cd55241f Verify that cap > floor (#807) 2019-05-13 13:11:07 -07:00
Ben Letham
269133c133 Change cross validation performance metrics to first aggregate over horizon before computing rolling average (#839, #863) 2019-05-08 10:47:26 -07:00
Ben Letham
e9c017ba01 Default to Newton optimizer if less than 100 datapoints (#842, #870, #888) 2019-05-07 11:47:36 -07:00
Ben Letham
16b0166518 Bump dplyr requirement to 0.7.7 (#781) 2019-05-06 16:44:48 -07:00
Ben Letham
ec7689f03e R fallback to Newton if non-zero return code from optimization, to match existing Py behavior (#654) 2019-05-06 09:49:29 -07:00
Ben Letham
c8f2e8f847 Warn in cross validation if initial period is less than seasonality (#557), and fix bug that can produce error if period > initial 2019-05-03 08:40:20 -07:00
Ben Letham
35d470cbff Meaningful error message if predict is called before fit (for #462) 2019-05-02 14:53:57 -07:00
Ben Letham
921b604022 Update R documentation 2019-03-22 11:08:09 -07:00
Ben Letham
c5db6f8619 Update R tests with condition.name 2019-03-22 10:52:53 -07:00
Olof Höjvall
0092638abe Added conditional seasonality for R (#894) 2019-03-22 10:43:52 -07:00
Sean J. Taylor
703c0731f6 Supress warning messages while building model 2018-12-20 17:04:03 -08:00
Sean J. Taylor
151c476030 Fixing bug on development version of R 2018-12-20 12:38:17 -08:00
Sean J. Taylor
211f30039a Updated changelog and date for R package 2018-12-18 23:07:58 -08:00
Sean J. Taylor
fbd3050a61 Update date in DESCRIPTION 2018-12-05 08:38:26 -08:00
Sean J. Taylor
a5da086ba0 Clean non-ASCII characters out of generated_holidays 2018-12-04 14:49:44 -08:00
Ben Letham
c9f1ccaa63 Version bump; test fixes; R build 2018-12-03 22:21:37 -08:00
Ben Letham
635ae5a1a6 Have fixed ordering for components plots 2018-12-03 20:14:24 -08:00
Ben Letham
1d398c679d Allow overriding any of the arguments to stan functions 2018-12-03 19:05:47 -08:00
Thomas J. Leeper
5f6612148a add Github URLs to DESCRIPTION (#761) 2018-12-03 17:01:01 -08:00
Ben Letham
13d96cff8f Fix type casting for extra regressors, and a shape issue 2018-12-03 15:22:19 -08:00
Ben Letham
fe677f290b Set rlang requirement to avoid bug in #592 2018-12-03 13:54:08 -08:00
Ben Letham
e3ad97b8b3 Documentation fixes 2018-12-03 13:25:26 -08:00
Ben Letham
536fe931c6 Add documentation for country holidays 2018-12-03 11:54:55 -08:00
Ben Letham
287fb2f6de Move built-in country holidays to a function (R) 2018-11-30 23:12:19 -08:00
Jennifer (Jenny) Bryan
ebf7b3da0a Apply colnames *before* coercing to a tbl_df (#739)
`dplyr::as_data_frame()` is really `tibble::as_tibble()`. An upcoming
release of tibble will be stricter about column names and, by default,
you can't have duplicate column names. This change allows prophet to
work with current CRAN tibble (v1.4.2) and the coming release.

cc @krlmlr
2018-11-21 09:34:17 -08:00
ziye666
95fa4460a9 Fix bug about holiday year different from input year and others (#670)
* Allow both both hoidays and append holidays

Match holidays in predict and fit

Add test for append_holiday features; minor fixes

Add column name validation for append_holidays names; allow only one country

Fix bug about holiday year different from input year and also other bugs

Change function description

Add append holiday feature for R

* Add test for R/Pyrhon; fix bugs
2018-10-18 17:40:17 -07:00
Sean J. Taylor
e3a0586c07 Add xts dependency back and regen docs 2018-06-14 18:42:11 -07:00
Sean J. Taylor
9beb1cb7e7 Version bumps before submitting new packages 2018-06-13 16:03:44 -07:00
Sean J. Taylor
cd84356968 Allow CRAN to build packages on OSX 2018-06-13 11:39:42 -07:00
Ben Letham
bc6360d115 Fix bug in seasonal components with MCMC 2018-06-12 16:53:14 -07:00
Sean J. Taylor
4f224e5ec7 Merge of v0.3 into master 2018-06-02 10:50:58 -07:00
Sean J. Taylor
b92d09cc82 Set dygraphs min version 2018-06-02 08:46:16 -07:00
Ben Letham
107f74f0f2 Allow constant extra regressors 2018-06-01 14:53:45 -07:00
Ben Letham
9a5338cbe4 Documentation update for new plot_components arg 2018-05-31 17:45:44 -07:00
Dmitrij Melichov
e5967a541e R make rendering of plots by method plot_components optional (#551) 2018-05-31 17:41:22 -07:00
Ben Letham
e0cf400e23 R check cleanups 2018-05-30 23:19:56 -07:00
bl
d589859295 Add link to main site from vignette 2018-05-30 17:10:59 -07:00
bl
371e8a3bf4 Version bump 2018-05-30 17:02:47 -07:00
bl
3b20680bfc Add test i386 test skips for stan tests 2018-05-30 16:40:34 -07:00
bl
f8775433c9 Remove vestigial comments, structure imports 2018-05-30 16:35:17 -07:00
bl
a38aaa38c6 Stan fix for pystan 2.16 2018-05-30 14:23:37 -07:00
Ben Letham
218283f157 Simplify logic/interfaces for cross_validation, to better handle irregularly spaced data and actually respect initial window 2018-05-30 12:09:54 -07:00
Ben Letham
cdc313584e Switch future changepoint generation to fully continuous model 2018-05-29 21:47:11 -07:00