* add test and initial function for mdape in R
* Add separate rolling_median_func and tests
* Modify rolling median function
* fix syntax in rolling median function
* sort by h
* R/diagnostics.R
* update .rd docs and notebook
* Add mdape to performance metrics params docstring
* Add test for custom cutoff cv
* implement custom cutoff logic in cv function
* add docstring
* add description in notebook and rebuild .Rd docs
* fix bug and add test case for period is NULL
* replace s.POSIXct set_date
I'm not sure why a data frame ends up with names and a tibble does not, but it doesn't seem like an important enough problem to investigate in detail, and this is a simple fix.
+ cleans up Stan model compilation by switching over to the rstantools-based workflow (see https://mc-stan.org/rstantools/articles/minimal-rstan-package.html for more info)
+ minor documentation change: {devtools} -> {remotes}, which is better for end-users
+ adds RStudio project file which makes it easier for community to get started with contributing to the package
* Pass ... from dyplot.prophet to dygraph to be able to set additional parameters
* Add documentation for ... in dyplot.prophet
Co-authored-by: Ben Letham <bletham@gmail.com>
Ensures that `add_regressor` and `add_seasonality` are valid column names
to R, to ensure that the generated columns are then used downstream to fit
the model.
Why not put it in `validate_column_names`? Because `validate_column_names` is
also used to validate if holiday names (which can be scalar values in columns) are
valid. We want to allow `c('seans-bday', 'Xmas')` as a valid holiday input, so we
cannot then put it there.
Tested these changes by using devtools::testthat().
Resolves: #996
In reverse order of importance, this change addresses:
- #980, by adding validation to ensure that `fourier.order` > 0
- changes all the tests that `expect_error` using the argument
`fourier_order`, as the argument is named `fourier.order`, so
the intent of the test is to validate the holiday names rather
than to check the use of the correct argument name
Resolves: #980
