From 967a17bb4ed49719b84d3212405879ba7325ed63 Mon Sep 17 00:00:00 2001 From: Ben Letham Date: Thu, 1 Feb 2018 16:47:54 -0800 Subject: [PATCH] Fix holiday window validation when NaNs are present --- python/fbprophet/forecaster.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/python/fbprophet/forecaster.py b/python/fbprophet/forecaster.py index d3cefc8..f421179 100644 --- a/python/fbprophet/forecaster.py +++ b/python/fbprophet/forecaster.py @@ -158,9 +158,9 @@ class Prophet(object): raise ValueError('Holidays must have both lower_window and ' + 'upper_window, or neither') if has_lower: - if max(self.holidays['lower_window']) > 0: + if self.holidays['lower_window'].max() > 0: raise ValueError('Holiday lower_window should be <= 0') - if min(self.holidays['upper_window']) < 0: + if self.holidays['upper_window'].min() < 0: raise ValueError('Holiday upper_window should be >= 0') for h in self.holidays['holiday'].unique(): self.validate_column_name(h, check_holidays=False)