From 0e0f1a607a57f4b21f66779e9c8144227edb748b Mon Sep 17 00:00:00 2001 From: Daniel Scally Date: Tue, 28 May 2019 21:51:01 +0100 Subject: [PATCH] Adding validation to Prophet.add_seasonality to prevent user setting fourier_order <= 0 --- python/fbprophet/forecaster.py | 2 ++ python/fbprophet/tests/test_prophet.py | 6 ++++++ 2 files changed, 8 insertions(+) diff --git a/python/fbprophet/forecaster.py b/python/fbprophet/forecaster.py index 5f3421f..29240e9 100644 --- a/python/fbprophet/forecaster.py +++ b/python/fbprophet/forecaster.py @@ -647,6 +647,8 @@ class Prophet(object): ps = float(prior_scale) if ps <= 0: raise ValueError('Prior scale must be > 0') + if fourier_order <= 0: + raise ValueError('Fourier Order must be > 0') if mode is None: mode = self.seasonality_mode if mode not in ['additive', 'multiplicative']: diff --git a/python/fbprophet/tests/test_prophet.py b/python/fbprophet/tests/test_prophet.py index 6c9570c..3f9415c 100644 --- a/python/fbprophet/tests/test_prophet.py +++ b/python/fbprophet/tests/test_prophet.py @@ -557,6 +557,12 @@ class TestProphet(TestCase): with self.assertRaises(ValueError): m.add_seasonality(name='trend', period=30, fourier_order=5) m.add_seasonality(name='weekly', period=30, fourier_order=5) + # Test fourier order <= 0 + m = Prophet() + with self.assertRaises(ValueError): + m.add_seasonality(name='weekly', period=7, fourier_order=0) + with self.assertRaises(ValueError): + m.add_seasonality(name='weekly', period=7, fourier_order=-1) # Test priors m = Prophet( holidays=holidays, yearly_seasonality=False,