From c8dedf2ec3ef6e808ec7019f5cc0a9882dd26704 Mon Sep 17 00:00:00 2001 From: Sean Bowe Date: Wed, 6 Jan 2021 10:47:06 -0700 Subject: [PATCH] Fix challenge multiplications as per #119. --- src/poly/multiopen/prover.rs | 4 ++-- src/poly/multiopen/verifier.rs | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/poly/multiopen/prover.rs b/src/poly/multiopen/prover.rs index 26be711..b9f8744 100644 --- a/src/poly/multiopen/prover.rs +++ b/src/poly/multiopen/prover.rs @@ -65,7 +65,7 @@ where // Each polynomial is evaluated at a set of points. For each set, // we collapse each polynomial's evals pointwise. for (eval, set_eval) in evals.iter().zip(q_eval_sets[set_idx].iter_mut()) { - *set_eval *= &x_1; + *set_eval *= &(*x_1); *set_eval += eval; } }; @@ -130,7 +130,7 @@ where |(f_poly, f_blind), (poly, blind)| { ( f_poly * *x_4 + poly.as_ref().unwrap(), - Blind((f_blind.0 * &x_4) + &blind.0), + Blind((f_blind.0 * &(*x_4)) + &blind.0), ) }, ); diff --git a/src/poly/multiopen/verifier.rs b/src/poly/multiopen/verifier.rs index dea3cf0..d34426a 100644 --- a/src/poly/multiopen/verifier.rs +++ b/src/poly/multiopen/verifier.rs @@ -56,7 +56,7 @@ where q_commitments[set_idx].scale(*x_1); q_commitments[set_idx].append_term(C::Scalar::one(), new_commitment); for (eval, set_eval) in evals.iter().zip(q_eval_sets[set_idx].iter_mut()) { - *set_eval *= &x_1; + *set_eval *= &(*x_1); *set_eval += eval; } }; @@ -98,7 +98,7 @@ where let eval = points.iter().fold(*proof_eval - &r_eval, |eval, point| { eval * &(*x_3 - point).invert().unwrap() }); - msm_eval * &x_2 + &eval + msm_eval * &(*x_2) + &eval }, ); @@ -113,7 +113,7 @@ where |(mut msm, msm_eval), (q_commitment, q_eval)| { msm.scale(*x_4); msm.add_msm(&q_commitment); - (msm, msm_eval * &x_4 + q_eval) + (msm, msm_eval * &(*x_4) + q_eval) }, );