clippy: Use *Assign to implement arithmetic::Group trait

src/curves.rs

@@ -730,13 +730,13 @@ macro_rules! new_curve_impl {
                 Self::identity()
             }
             fn group_add(&mut self, rhs: &Self) {
-                *self = *self + *rhs;
+                *self += *rhs;
             }
             fn group_sub(&mut self, rhs: &Self) {
-                *self = *self - *rhs;
+                *self -= *rhs;
             }
             fn group_scale(&mut self, by: &Self::Scalar) {
-                *self = *self * (*by);
+                *self *= *by;
             }
         }
     };

src/fields/fp.rs

@@ -451,13 +451,13 @@ impl Group for Fp {
         Self::zero()
     }
     fn group_add(&mut self, rhs: &Self) {
-        *self = *self + *rhs;
+        *self += *rhs;
     }
     fn group_sub(&mut self, rhs: &Self) {
-        *self = *self - *rhs;
+        *self -= *rhs;
     }
     fn group_scale(&mut self, by: &Self::Scalar) {
-        *self = *self * (*by);
+        *self *= *by;
     }
 }
 

src/fields/fq.rs

@@ -451,13 +451,13 @@ impl Group for Fq {
         Self::zero()
     }
     fn group_add(&mut self, rhs: &Self) {
-        *self = *self + *rhs;
+        *self += *rhs;
     }
     fn group_sub(&mut self, rhs: &Self) {
-        *self = *self - *rhs;
+        *self -= *rhs;
     }
     fn group_scale(&mut self, by: &Self::Scalar) {
-        *self = *self * (*by);
+        *self *= *by;
     }
 }
 

src/lib.rs

@@ -4,7 +4,6 @@
 #![allow(unknown_lints)]
 #![allow(
     clippy::op_ref,
-    clippy::assign_op_pattern,
     clippy::too_many_arguments,
     clippy::suspicious_arithmetic_impl,
     clippy::many_single_char_names,