onnxruntime/tools/nuget/validate_package.py
Yi Zhang 3f03c12986
Split Onnxruntime Nuget GPU package (#18819)
### Description
1. Update donwload-artifacts to flex-downloadartifacts to make it eaiser
to debug.
2. Move the native files into Gpu.Windows and Gpu-linux packages.
Onnxruntime-Gpu has dependency on them.
3. update the package validation as well
4. Add 2 stages to run E2E test for GPU.Windows and GPU.Linux
   for example:
   

![image](https://github.com/microsoft/onnxruntime/assets/16190118/35c6730b-8080-4f52-a17c-b9c61f41b6bb)



### Motivation and Context
Single Onnxruntime.Gpu Package size has already excceded the Nuget size
limit.
We split the package into some smaller packages to make them can be
published.

For compatibility, the user can install or upgrade Onnxruntime.Gpu,
which will install Gpu.Windows and Gpu.Linux automatically.
And the user can only install Gpu.Windows and Gpu.Linux directly. 

### Test Link
1. In ORT_NIGHTLY

2. Install the preview version in nuget-int. (nuget source:
https://apiint.nugettest.org/v3/index.json)

---------

Co-authored-by: Scott McKay <skottmckay@gmail.com>
2023-12-22 16:57:16 +08:00

393 lines
14 KiB
Python

# Copyright (c) Microsoft Corporation. All rights reserved.
# Licensed under the MIT License.
import argparse
import glob
import os
import re
import sys
import zipfile # Available Python 3.2 or higher
linux_gpu_package_libraries = [
"libonnxruntime_providers_shared.so",
"libonnxruntime_providers_cuda.so",
"libonnxruntime_providers_tensorrt.so",
]
win_gpu_package_libraries = [
"onnxruntime_providers_shared.lib",
"onnxruntime_providers_shared.dll",
"onnxruntime_providers_cuda.lib",
"onnxruntime_providers_cuda.dll",
"onnxruntime_providers_tensorrt.lib",
"onnxruntime_providers_tensorrt.dll",
]
gpu_related_header_files = [
"cpu_provider_factory.h",
"onnxruntime_c_api.h",
"onnxruntime_cxx_api.h",
"onnxruntime_float16.h",
"onnxruntime_cxx_inline.h",
]
dmlep_related_header_files = [
"cpu_provider_factory.h",
"onnxruntime_c_api.h",
"onnxruntime_cxx_api.h",
"onnxruntime_float16.h",
"onnxruntime_cxx_inline.h",
"dml_provider_factory.h",
]
training_related_header_files = [
"onnxruntime_c_api.h",
"onnxruntime_float16.h",
"onnxruntime_cxx_api.h",
"onnxruntime_cxx_inline.h",
"onnxruntime_training_c_api.h",
"onnxruntime_training_cxx_api.h",
"onnxruntime_training_cxx_inline.h",
]
def parse_arguments():
parser = argparse.ArgumentParser(
description="Validate ONNX Runtime native nuget containing native shared library artifacts spec script",
usage="",
)
# Main arguments
parser.add_argument("--package_type", required=True, help="Specify nuget, tarball or zip.")
parser.add_argument("--package_name", required=True, help="Package name to be validated.")
parser.add_argument(
"--package_path",
required=True,
help="Path containing the package to be validated. Must only contain only one package within this.",
)
parser.add_argument(
"--platforms_supported", required=True, help="Comma separated list (no space). Ex: linux-x64,win-x86,osx-x64"
)
parser.add_argument(
"--verify_nuget_signing",
help="Flag indicating if Nuget package signing is to be verified. Only accepts 'true' or 'false'",
)
return parser.parse_args()
def check_exists(path):
return os.path.exists(path)
def remove_residual_files(path):
if check_exists(path):
os.remove(path)
def is_windows():
return sys.platform.startswith("win")
def check_if_headers_are_present(header_files, header_folder, file_list_in_package, platform):
for header in header_files:
path = header_folder + "/" + header
print("Checking path: " + path)
if path not in file_list_in_package:
print(header + " not found for " + platform)
raise Exception(header + " not found for " + platform)
def check_if_dlls_are_present(
package_type,
is_windows_ai_package,
is_gpu_package,
is_dml_package,
is_training_package,
platforms_supported,
zip_file,
package_path,
is_gpu_dependent_package=False, # only used for nuget packages
):
platforms = platforms_supported.strip().split(",")
if package_type == "tarball":
file_list_in_package = list()
for dirpath, _dirnames, filenames in os.walk(package_path):
file_list_in_package += [os.path.join(dirpath, file) for file in filenames]
else:
file_list_in_package = zip_file.namelist()
print(file_list_in_package)
# In Nuget GPU package, onnxruntime.dll is in dependent package.
package_contains_library = not bool(package_type == "nuget" and is_gpu_package)
# In Nuget GPU package, gpu header files are not in dependent package.
package_contains_headers = bool(
(is_gpu_package and package_type != "nuget") or (package_type == "nuget" and not is_gpu_package)
)
# In Nuget GPU package, cuda ep and tensorrt ep dlls are in dependent package
package_contains_cuda_binaries = bool((is_gpu_package and package_type != "nuget") or is_gpu_dependent_package)
for platform in platforms:
if platform.startswith("win"):
native_folder = "_native" if is_windows_ai_package else "native"
if package_type == "nuget":
folder = "runtimes/" + platform + "/" + native_folder
build_dir = "buildTransitive" if is_gpu_dependent_package else "build"
header_folder = f"{build_dir}/native/include"
else: # zip package
folder = package_path + "/lib"
header_folder = package_path + "/include"
# In Nuget GPU package, onnxruntime.dll is in dependent package.
if package_contains_library:
path = folder + "/" + "onnxruntime.dll"
print("Checking path: " + path)
if path not in file_list_in_package:
print("onnxruntime.dll not found for " + platform)
raise Exception("onnxruntime.dll not found for " + platform)
if package_contains_cuda_binaries:
for dll in win_gpu_package_libraries:
path = folder + "/" + dll
print("Checking path: " + path)
if path not in file_list_in_package:
print(dll + " not found for " + platform)
raise Exception(dll + " not found for " + platform)
if package_contains_headers:
check_if_headers_are_present(gpu_related_header_files, header_folder, file_list_in_package, platform)
if is_dml_package:
check_if_headers_are_present(dmlep_related_header_files, header_folder, file_list_in_package, platform)
if is_training_package:
check_if_headers_are_present(
training_related_header_files, header_folder, file_list_in_package, platform
)
elif platform.startswith("linux"):
if package_type == "nuget":
folder = "runtimes/" + platform + "/native"
build_dir = "buildTransitive" if is_gpu_dependent_package else "build"
header_folder = f"{build_dir}/native/include"
else: # tarball package
folder = package_path + "/lib"
header_folder = package_path + "/include"
if package_contains_library:
path = folder + "/" + "libonnxruntime.so"
print("Checking path: " + path)
if path not in file_list_in_package:
print("libonnxruntime.so not found for " + platform)
raise Exception("libonnxruntime.so not found for " + platform)
if package_contains_cuda_binaries:
for so in linux_gpu_package_libraries:
path = folder + "/" + so
print("Checking path: " + path)
if path not in file_list_in_package:
print(so + " not found for " + platform)
raise Exception(so + " not found for " + platform)
if package_contains_headers:
for header in gpu_related_header_files:
path = header_folder + "/" + header
print("Checking path: " + path)
if path not in file_list_in_package:
print(header + " not found for " + platform)
raise Exception(header + " not found for " + platform)
elif platform.startswith("osx"):
path = "runtimes/" + platform + "/native/libonnxruntime.dylib"
print("Checking path: " + path)
if path not in file_list_in_package:
print("libonnxruntime.dylib not found for " + platform)
raise Exception("libonnxruntime.dylib not found for " + platform)
else:
raise Exception("Unsupported platform: " + platform)
def check_if_nuget_is_signed(nuget_path):
code_sign_summary_file = glob.glob(os.path.join(nuget_path, "*.md"))
if len(code_sign_summary_file) != 1:
print("CodeSignSummary files found in path: ")
print(code_sign_summary_file)
raise Exception("No CodeSignSummary files / more than one CodeSignSummary files found in the given path.")
print("CodeSignSummary file: " + code_sign_summary_file[0])
with open(code_sign_summary_file[0]) as f:
contents = f.read()
return "Pass" in contents
return False
def validate_tarball(args):
files = glob.glob(os.path.join(args.package_path, args.package_name))
if len(files) != 1:
print("packages found in path: ")
print(files)
raise Exception("No packages / more than one packages found in the given path.")
package_name = args.package_name
if "-gpu-" in package_name.lower():
is_gpu_package = True
else:
is_gpu_package = False
package_folder = re.search("(.*)[.].*", package_name).group(1)
print("tar zxvf " + package_name)
os.system("tar zxvf " + package_name)
is_windows_ai_package = False
zip_file = None
is_dml_package = False
is_training_package = False
check_if_dlls_are_present(
args.package_type,
is_windows_ai_package,
is_gpu_package,
is_dml_package,
is_training_package,
args.platforms_supported,
zip_file,
package_folder,
)
def validate_zip(args):
files = glob.glob(os.path.join(args.package_path, args.package_name))
if len(files) != 1:
print("packages found in path: ")
print(files)
raise Exception("No packages / more than one packages found in the given path.")
package_name = args.package_name
if "-gpu-" in package_name.lower():
is_gpu_package = True
else:
is_gpu_package = False
package_folder = re.search("(.*)[.].*", package_name).group(1)
is_windows_ai_package = False
is_dml_package = False
is_training_package = False
zip_file = zipfile.ZipFile(package_name)
check_if_dlls_are_present(
args.package_type,
is_windows_ai_package,
is_gpu_package,
is_dml_package,
is_training_package,
args.platforms_supported,
zip_file,
package_folder,
)
def validate_nuget(args):
files = glob.glob(os.path.join(args.package_path, args.package_name))
nuget_packages_found_in_path = [i for i in files if i.endswith(".nupkg") and "Managed" not in i]
if len(nuget_packages_found_in_path) != 1:
print("Nuget packages found in path: ")
print(nuget_packages_found_in_path)
raise Exception("No Nuget packages / more than one Nuget packages found in the given path.")
nuget_file_name = nuget_packages_found_in_path[0]
full_nuget_path = os.path.join(args.package_path, nuget_file_name)
is_gpu_package = bool("microsoft.ml.onnxruntime.gpu.1" in args.package_name.lower())
is_gpu_dependent_package = bool(
"microsoft.ml.onnxruntime.gpu.windows" in args.package_name.lower()
or "microsoft.ml.onnxruntime.gpu.linux" in args.package_name.lower()
)
if "directml" in nuget_file_name.lower():
is_dml_package = True
else:
is_dml_package = False
if "Training" in nuget_file_name:
is_training_package = True
else:
is_training_package = False
exit_code = 0
nupkg_copy_name = "NugetCopy.nupkg"
zip_copy_name = "NugetCopy.zip"
zip_file = None
# Remove any residual files
remove_residual_files(nupkg_copy_name)
remove_residual_files(zip_copy_name)
# Do all validations here
try:
if not is_windows():
raise Exception("Nuget validation is currently supported only on Windows")
# Make a copy of the Nuget package
print("Copying [" + full_nuget_path + "] -> [" + nupkg_copy_name + "], and extracting its contents")
os.system("copy " + full_nuget_path + " " + nupkg_copy_name)
# Convert nupkg to zip
os.rename(nupkg_copy_name, zip_copy_name)
zip_file = zipfile.ZipFile(zip_copy_name)
# Check if the relevant dlls are present in the Nuget/Zip
print("Checking if the Nuget contains relevant dlls")
is_windows_ai_package = os.path.basename(full_nuget_path).startswith("Microsoft.AI.MachineLearning")
check_if_dlls_are_present(
args.package_type,
is_windows_ai_package,
is_gpu_package,
is_dml_package,
is_training_package,
args.platforms_supported,
zip_file,
None,
is_gpu_dependent_package,
)
verify_nuget_signing = args.verify_nuget_signing.lower()
# Check if the Nuget has been signed
if verify_nuget_signing != "true" and verify_nuget_signing != "false":
raise Exception("Parameter verify_nuget_signing accepts only true or false as an argument")
if verify_nuget_signing == "true":
print("Verifying if Nuget has been signed")
if not check_if_nuget_is_signed(args.package_path):
print("Nuget signing verification failed")
raise Exception("Nuget signing verification failed")
except Exception as e:
print(e)
exit_code = 1
finally:
print("Cleaning up after Nuget validation")
if zip_file is not None:
zip_file.close()
if check_exists(zip_copy_name):
os.remove(zip_copy_name)
if exit_code == 0:
print("Nuget validation was successful")
else:
raise Exception("Nuget validation was unsuccessful")
def main():
args = parse_arguments()
if args.package_type == "nuget":
validate_nuget(args)
elif args.package_type == "tarball":
validate_tarball(args)
elif args.package_type == "zip":
validate_zip(args)
else:
print(f"Package type {args.package_type} is not supported")
if __name__ == "__main__":
sys.exit(main())