mirror of
https://github.com/saymrwulf/onnxruntime.git
synced 2026-05-24 22:17:32 +00:00
d834ec895a
### Description `lintrunner` is a linter runner successfully used by pytorch, onnx and onnx-script. It provides a uniform experience running linters locally and in CI. It supports all major dev systems: Windows, Linux and MacOs. The checks are enforced by the `Python format` workflow. This PR adopts `lintrunner` to onnxruntime and fixed ~2000 flake8 errors in Python code. `lintrunner` now runs all required python lints including `ruff`(replacing `flake8`), `black` and `isort`. Future lints like `clang-format` can be added. Most errors are auto-fixed by `ruff` and the fixes should be considered robust. Lints that are more complicated to fix are applied `# noqa` for now and should be fixed in follow up PRs. ### Notable changes 1. This PR **removed some suboptimal patterns**: - `not xxx in` -> `xxx not in` membership checks - bare excepts (`except:` -> `except Exception`) - unused imports The follow up PR will remove: - `import *` - mutable values as default in function definitions (`def func(a=[])`) - more unused imports - unused local variables 2. Use `ruff` to replace `flake8`. `ruff` is much (40x) faster than flake8 and is more robust. We are using it successfully in onnx and onnx-script. It also supports auto-fixing many flake8 errors. 3. Removed the legacy flake8 ci flow and updated docs. 4. The added workflow supports SARIF code scanning reports on github, example snapshot:  5. Removed `onnxruntime-python-checks-ci-pipeline` as redundant ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> Unified linting experience in CI and local. Replacing https://github.com/microsoft/onnxruntime/pull/14306 --------- Signed-off-by: Justin Chu <justinchu@microsoft.com>
103 lines
3.9 KiB
Python
103 lines
3.9 KiB
Python
# -------------------------------------------------------------------------
|
|
# Copyright (c) Microsoft Corporation. All rights reserved.
|
|
# Licensed under the MIT License.
|
|
# --------------------------------------------------------------------------
|
|
import ctypes
|
|
import sys
|
|
import warnings
|
|
|
|
|
|
def find_cudart_versions(build_env=False, build_cuda_version=None):
|
|
# ctypes.CDLL and ctypes.util.find_library load the latest installed library.
|
|
# it may not the the library that would be loaded by onnxruntime.
|
|
# for example, in an environment with Cuda 11.1 and subsequently
|
|
# conda cudatoolkit 10.2.89 installed. ctypes will find cudart 10.2. however,
|
|
# onnxruntime built with Cuda 11.1 will find and load cudart for Cuda 11.1.
|
|
# for the above reason, we need find all versions in the environment and
|
|
# only give warnings if the expected cuda version is not found.
|
|
# in onnxruntime build environment, we expected only one Cuda version.
|
|
if not sys.platform.startswith("linux"):
|
|
warnings.warn("find_cudart_versions only works on Linux")
|
|
return None
|
|
|
|
cudart_possible_versions = {None, build_cuda_version}
|
|
|
|
def get_cudart_version(find_cudart_version=None):
|
|
cudart_lib_filename = "libcudart.so"
|
|
if find_cudart_version:
|
|
cudart_lib_filename = cudart_lib_filename + "." + find_cudart_version
|
|
|
|
try:
|
|
cudart = ctypes.CDLL(cudart_lib_filename)
|
|
cudart.cudaRuntimeGetVersion.restype = int
|
|
cudart.cudaRuntimeGetVersion.argtypes = [ctypes.POINTER(ctypes.c_int)]
|
|
version = ctypes.c_int()
|
|
status = cudart.cudaRuntimeGetVersion(ctypes.byref(version))
|
|
if status != 0:
|
|
return None
|
|
except Exception:
|
|
return None
|
|
|
|
return version.value
|
|
|
|
# use set to avoid duplications
|
|
cudart_found_versions = {get_cudart_version(cudart_version) for cudart_version in cudart_possible_versions}
|
|
|
|
# convert to list and remove None
|
|
return [ver for ver in cudart_found_versions if ver]
|
|
|
|
|
|
def find_cudnn_supported_cuda_versions(build_env=False):
|
|
# comments in get_cudart_version apply here
|
|
if not sys.platform.startswith("linux"):
|
|
warnings.warn("find_cudnn_versions only works on Linux")
|
|
|
|
cudnn_possible_versions = {None}
|
|
if not build_env:
|
|
# if not in a build environment, there may be more than one installed cudnn.
|
|
# https://developer.nvidia.com/rdp/cudnn-archive to include all that may support Cuda 10+.
|
|
cudnn_possible_versions.update(
|
|
{
|
|
"8.2",
|
|
"8.1.1",
|
|
"8.1.0",
|
|
"8.0.5",
|
|
"8.0.4",
|
|
"8.0.3",
|
|
"8.0.2",
|
|
"8.0.1",
|
|
"7.6.5",
|
|
"7.6.4",
|
|
"7.6.3",
|
|
"7.6.2",
|
|
"7.6.1",
|
|
"7.6.0",
|
|
"7.5.1",
|
|
"7.5.0",
|
|
"7.4.2",
|
|
"7.4.1",
|
|
"7.3.1",
|
|
"7.3.0",
|
|
}
|
|
)
|
|
|
|
def get_cudnn_supported_cuda_version(find_cudnn_version=None):
|
|
cudnn_lib_filename = "libcudnn.so"
|
|
if find_cudnn_version:
|
|
cudnn_lib_filename = cudnn_lib_filename + "." + find_cudnn_version
|
|
|
|
# in cudnn.h cudnn version are calculated as:
|
|
# #define CUDNN_VERSION (CUDNN_MAJOR * 1000 + CUDNN_MINOR * 100 + CUDNN_PATCHLEVEL)
|
|
try:
|
|
cudnn = ctypes.CDLL(cudnn_lib_filename)
|
|
# cudnn_ver = cudnn.cudnnGetVersion()
|
|
cuda_ver = cudnn.cudnnGetCudartVersion()
|
|
return cuda_ver
|
|
except Exception:
|
|
return None
|
|
|
|
# use set to avoid duplications
|
|
cuda_found_versions = {get_cudnn_supported_cuda_version(cudnn_version) for cudnn_version in cudnn_possible_versions}
|
|
|
|
# convert to list and remove None
|
|
return [ver for ver in cuda_found_versions if ver]
|