mirror of
https://github.com/saymrwulf/onnxruntime.git
synced 2026-05-14 20:48:00 +00:00
8ff41aea09
### Description <!-- Describe your changes. --> Fix bad delegates. Add script to detect mismatch, and run in CI and when creating nuget package. Ignore whitespace when looking at the diff to the .cs file as clang-format ran. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> #18363
62 lines
2.3 KiB
Python
62 lines
2.3 KiB
Python
#!/usr/bin/env python3
|
|
# Copyright (c) Microsoft Corporation. All rights reserved.
|
|
# Licensed under the MIT License.
|
|
|
|
import argparse
|
|
import pathlib
|
|
|
|
|
|
def check_all_delegates_have_unmanaged_function_pointer_attribute(file: pathlib.Path):
|
|
"""
|
|
Check that all 'public delegate' declarations have a matching UnmanagedFunctionPointer attribute.
|
|
:param file: C# source file to check.
|
|
:return: Number of errors
|
|
"""
|
|
|
|
print(f"Checking {file!s}")
|
|
|
|
errors = 0
|
|
line_num = 0
|
|
with open(str(file.resolve(strict=True))) as f:
|
|
prev_line = ""
|
|
for line in f.readlines():
|
|
line_num += 1
|
|
|
|
# strip so it's easier to deal with commented out lines.
|
|
line = line.strip() # noqa
|
|
if line.startswith("public delegate ") and not prev_line.startswith("[UnmanagedFunctionPointer"):
|
|
errors += 1
|
|
print(f"Line {line_num} is missing UnmanagedFunctionPointer attribute:\n\t{prev_line}\n\t{line}")
|
|
|
|
prev_line = line
|
|
|
|
return errors
|
|
|
|
|
|
def main():
|
|
arg_parser = argparse.ArgumentParser(
|
|
"Script to validate that the native delegates for the ONNX Runtime C# managed projects have the required "
|
|
"attributes for iOS AOT. Paths are inferred from the script location."
|
|
"Errors of this nature can only be detected at runtime, in a release build, of a Xamarin/MAUI app, "
|
|
"on an actual iOS device. Due to that we take extra steps to identify problems early."
|
|
)
|
|
|
|
# no real args. just using this to provide description as help message
|
|
_ = arg_parser.parse_args()
|
|
|
|
# CI needs resolve() as __file__ is a relative path when the script is run there
|
|
script_dir = pathlib.Path(__file__).resolve().parent
|
|
csharp_root = script_dir.parent
|
|
|
|
managed_dir = csharp_root / "src" / "Microsoft.ML.OnnxRuntime"
|
|
native_methods = managed_dir / "NativeMethods.shared.cs"
|
|
training_native_methods = managed_dir / "Training" / "NativeTrainingMethods.shared.cs"
|
|
errors = check_all_delegates_have_unmanaged_function_pointer_attribute(native_methods)
|
|
errors += check_all_delegates_have_unmanaged_function_pointer_attribute(training_native_methods)
|
|
|
|
if errors:
|
|
raise ValueError(f"{errors} errors were found. Please check output for specifics.")
|
|
|
|
|
|
if __name__ == "__main__":
|
|
main()
|