mirror of
https://github.com/saymrwulf/onnxruntime.git
synced 2026-07-05 04:17:53 +00:00
d834ec895a
### Description `lintrunner` is a linter runner successfully used by pytorch, onnx and onnx-script. It provides a uniform experience running linters locally and in CI. It supports all major dev systems: Windows, Linux and MacOs. The checks are enforced by the `Python format` workflow. This PR adopts `lintrunner` to onnxruntime and fixed ~2000 flake8 errors in Python code. `lintrunner` now runs all required python lints including `ruff`(replacing `flake8`), `black` and `isort`. Future lints like `clang-format` can be added. Most errors are auto-fixed by `ruff` and the fixes should be considered robust. Lints that are more complicated to fix are applied `# noqa` for now and should be fixed in follow up PRs. ### Notable changes 1. This PR **removed some suboptimal patterns**: - `not xxx in` -> `xxx not in` membership checks - bare excepts (`except:` -> `except Exception`) - unused imports The follow up PR will remove: - `import *` - mutable values as default in function definitions (`def func(a=[])`) - more unused imports - unused local variables 2. Use `ruff` to replace `flake8`. `ruff` is much (40x) faster than flake8 and is more robust. We are using it successfully in onnx and onnx-script. It also supports auto-fixing many flake8 errors. 3. Removed the legacy flake8 ci flow and updated docs. 4. The added workflow supports SARIF code scanning reports on github, example snapshot:  5. Removed `onnxruntime-python-checks-ci-pipeline` as redundant ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> Unified linting experience in CI and local. Replacing https://github.com/microsoft/onnxruntime/pull/14306 --------- Signed-off-by: Justin Chu <justinchu@microsoft.com>
47 lines
1.5 KiB
Python
47 lines
1.5 KiB
Python
#!/usr/bin/env python
|
|
# -------------------------------------------------------------------------
|
|
# Copyright (c) Microsoft Corporation. All rights reserved.
|
|
# Licensed under the MIT License. See License.txt in the project root for
|
|
# license information.
|
|
# --------------------------------------------------------------------------
|
|
|
|
# For live logging, use the command: pytest -o log_cli=true --log-cli-level=DEBUG
|
|
|
|
import os
|
|
import unittest
|
|
|
|
import pytest
|
|
from test_optimizer import _get_test_model_path
|
|
|
|
|
|
class TestBertProfiler(unittest.TestCase):
|
|
def setUp(self):
|
|
from onnxruntime import get_available_providers
|
|
|
|
self.test_cuda = "CUDAExecutionProvider" in get_available_providers()
|
|
|
|
def run_profile(self, arguments: str):
|
|
from onnxruntime.transformers.profiler import parse_arguments, run
|
|
|
|
args = parse_arguments(arguments.split())
|
|
results = run(args)
|
|
self.assertTrue(len(results) > 1)
|
|
|
|
@pytest.mark.slow
|
|
def test_profiler_gpu(self):
|
|
input_model_path = _get_test_model_path("bert_keras_squad")
|
|
if self.test_cuda:
|
|
self.run_profile(f"--model {input_model_path} --batch_size 1 --sequence_length 7 --use_gpu")
|
|
|
|
@pytest.mark.slow
|
|
def test_profiler_cpu(self):
|
|
input_model_path = _get_test_model_path("bert_keras_squad")
|
|
self.run_profile(f"--model {input_model_path} --batch_size 1 --sequence_length 7 --dummy_inputs default")
|
|
|
|
|
|
if __name__ == "__main__":
|
|
import sys
|
|
|
|
sys.path.append(os.path.join(os.path.dirname(__file__), ".."))
|
|
|
|
unittest.main()
|