Commit graph

3 commits

Author SHA1 Message Date
Changming Sun
051ee681a3
Add a few suggestions to coding guideline (#1238)
* Add a few suggestions to coding guideline
2019-06-18 19:28:21 -07:00
Scott McKay
4a8d75386b
Clarify/state expected usage of non-const references and 'auto' in coding conventions (#1096)
* As we consistently use non-const reference for modifiable arguments that cannot be null, update the conventions to reflect that.

Add a note on qualifying 'auto' to make the intent clearer and it easier to notice accidental copies.

* Address PR comment by adding a statement around disabling copy/assignment/move for new classes until needed.
2019-05-23 19:28:01 -07:00
Pranav Sharma
89618e8f1e Initial bootstrap commit. 2018-11-19 16:48:22 -08:00