Commit graph

67 commits

Author SHA1 Message Date
Ori Levari
6ad3e74f4a
Filter CPU case for IsFloat16Supported (#2802) 2020-01-13 13:56:14 -08:00
Ryan Lai
8d017f5701
Scneario Test : Build Google Test and Taef Test based on preprocessor definition (#2809)
* Add winml macro wrappers on top of google test macros

* change test methods to disabled

* Add custom winml macros for both taef and google tests

* PR comments
2020-01-13 09:22:54 -08:00
Ryan Lai
5122dbf8b1
Remove usage of WHOLEARCHIVE in WinML CMake and add WinMLAdapterFactory (#2726)
* Remove usage of WHOLEARCHIVE in WinMLAdapter CMake and add WinMLAdapterFactory

* PR feedback, no need for dll(export) since using def file

* PR comments

* Small comment in gen_def.py
2020-01-02 16:09:30 -08:00
Xiang Zhang
a3750c102f
send shutdown event when dll is unloaded and EvaluationStop, SessionC… (#2704)
* send shutdown event when dll is unloaded and EvaluationStop, SessionCreationStart Events.

* Add EvalutationStart Event

* add comment
2019-12-20 16:11:21 -08:00
Ryan Lai
3429b0f556 Deref unique pointer for session_state 2019-12-19 16:55:17 -08:00
Ryan Lai
4ccbd52242 Revert "User/orilevari/windowsai master merge (#2674)"
This reverts commit fe26146311.
2019-12-19 16:11:48 -08:00
Ori Levari
1eb584d97f
various changes to properly organize and skip GPU tests. For now for No DML builds we will not run GPU tests at all. In the future we should adapt the tests to expect the appropiate errors. (#2695) 2019-12-18 14:57:27 -08:00
Tiago Koji Castro Shibata
5901421798
Fix memory leaks (#2679)
Fix https://microsoft.visualstudio.com/OS/_workitems/edit/24356109,
https://microsoft.visualstudio.com/OS/_workitems/edit/24388361 and
https://microsoft.visualstudio.com/OS/_workitems/edit/24388596
2019-12-17 15:08:59 -08:00
Ryan Lai
b28a3a92e6
Delete Ort Allocator in LearningModelBinding (#2653)
* Delete OrtAllocator in LearningModelBinding

* PR comments to make Ort::Allocator a smart pointer

* Small comment change

* PR feedback to clean up code

* PR feedback on move semantics

* Clean up std::move
2019-12-17 14:58:46 -08:00
Ori Levari
fe26146311
User/orilevari/windowsai master merge (#2674)
merge resolutions included pulling in telemetry logic that was merged to master and not windowsai and dereferencing InferenceSession::sessionstate now that it is a unique pointer
2019-12-17 12:23:40 -08:00
Tiago Koji Castro Shibata
13c2eb3524
Fix leaking operator registry (#2645)
Fix https://microsoft.visualstudio.com/OS/_workitems/edit/24354916
2019-12-16 15:41:54 -08:00
Ryan Lai
7a812dfc02
merge changes from layer_dev to windowsai (#2638)
* Remove underscore from googletest names (#2616)

* Fix leaking memory allocator

Fix https://microsoft.visualstudio.com/OS/_workitems/edit/24278761
and https://microsoft.visualstudio.com/OS/_workitems/edit/24330198

* Explicitly initialize Ort::Value with nullptr

* Cache WinML adapter

* bad merge
2019-12-11 17:56:18 -08:00
Xiang Zhang
5c28eb61d5
User/xianz/dedup telemetry (#2631)
* investigate duplication of telemetry in winml and ort

* remove winml telemetry events

* telemetry executionProviderEvent

* remove unneccessary file and refactor code little bit

* Revert back TelemetryEvent, which send up ETW event.
2019-12-11 16:21:57 -08:00
Ryan Lai
75fbaa7255
Remove uwp onsuspending winrt call because logruntimeperf is getting removed (#2630) 2019-12-11 15:06:49 -08:00
Xiang Zhang
352c58d1b9
User/xianz/ortthrow (#2599)
* thrown and handle onnxruntime exceptions

* handle exception thrown from ort in winmladapter

* undo changes in error.h

* add message to HRESULT

* add status error message
2019-12-11 13:09:54 -08:00
Xiang Zhang
36e557ec12
User/xianz/ortthrow (#2596)
* thrown and handle onnxruntime exceptions

* handle exception thrown from ort in winmladapter

* undo changes in error.h

* add message to HRESULT
2019-12-09 16:44:55 -08:00
Ryan Lai
b248f2979a
Throw Winml_err_invalid_binding if binding gpu resource on cpu device (#2589)
* Throw Winml_err_invalid_binding if binding gpu resource on cpu device

* PR comments. No need to query executionprovider for is gpu device
2019-12-09 12:00:57 -08:00
Ori Levari
be48f05c64
Cmake and preprocessor fixes that where uncovered by building on agents without DML available via SDK 2019-12-06 13:30:19 -08:00
Paul McDaniel
56cbd82c71
Layer dev paulm (#2567)
* commetns for dml graph transformer
fixed ort value passing using the allocatir info

* fixed and coded maps and sequences across the abi

* cleaned up w4's
cleaned up the model info ABI
delayload directml.dll from winml

* cleaned up namepsace aliases.
renamed _winmla to winmla
this was good PR feedback from tiago a while back.

* moved files from inc to lib\api.core
cleaned up some of the cmake

* staged changes

* making windowsAI azure dev ops work.

* code review comments.

* revert changes
2019-12-05 18:14:20 -08:00
Ryan Lai
9933b8a5d6
Fix custom ops scenario tests (#2562)
* Do not shutdown protobuf after ort environment gets destroyed. Lazy load lotus environment first time it is needed

* comment typo

* pr comment  about calling phoenix singleton

* Make lotus_environment static in winmladapter
2019-12-05 15:41:01 -08:00
Xiang Zhang
8fb7b88e0a
Handle exception thrown from all apis in WinMLAdapter (#2539) 2019-12-04 14:08:16 -08:00
Ori Levari
2b8d6d3e31 add missing namespace to winml_trace_logging_provider in lotusenvironment.h (#2542) 2019-12-04 11:30:45 -08:00
Paul McDaniel
a7cf316efb
Layer dev paulm (#2536)
ori said yes
2019-12-03 16:35:27 -08:00
Ryan Lai
3afb7a89fe
Spawn child process to run DeviceLostRecovery scenario test (#2530)
* Spawn child process to run DeviceLostRecovery scenario test
2019-12-03 15:38:04 -08:00
Paul McDaniel
c615002f5d
Layer dev paulm (#2533)
* commetns for dml graph transformer
fixed ort value passing using the allocatir info

* fixed and coded maps and sequences across the abi

* cleaned up w4's
cleaned up the model info ABI
delayload directml.dll from winml

* cleaned up namepsace aliases.
renamed _winmla to winmla
this was good PR feedback from tiago a while back.

* moved files from inc to lib\api.core
cleaned up some of the cmake

* staged changes
2019-12-03 15:31:22 -08:00
Brian Martin
f54625f7c5
re-enable warnings for winml builds and fix the warnings that were hiding (#2526)
* turn devmode back on for winml builds

* fix some warnings. include protobuf in a way that disables some warnings

* undo protobufhelpers changes and just ignore 4100 errors in pb code

* attempt to isolate protobufhelpers errors

* add template specialization for getting tensor proto data
2019-12-03 09:57:56 -08:00
Paul McDaniel
301d407b39
Layer dev paulm (#2507)
* commetns for dml graph transformer
fixed ort value passing using the allocatir info

* fixed and coded maps and sequences across the abi

* cleaned up w4's
cleaned up the model info ABI
delayload directml.dll from winml

* cleaned up namepsace aliases.
renamed _winmla to winmla
this was good PR feedback from tiago a while back.
2019-11-27 15:50:49 -08:00
Ryan Lai
197fd9ea3d
Remove usage of IOBinding in WinML and use C_API Run method (#2504)
* remove usage of iobinding

* Change data structure to use vector of Ort::Values

* Polish bind input / output

* Use C APIrun method

* Update providers on evaluate getresults

* Remove run and IObinding interface from WinMLAdapter

* Remove use of IObinding

* bind unbound outputs code moved to learningmodelbinding

* clean up unneeded istensor adapter function

* Fix comment

* Check if session is closed before binding and clearing

* PR feedback
2019-11-27 15:31:30 -08:00
Paul McDaniel
e8e285dd97
Layer dev paulm (#2506)
* commetns for dml graph transformer
fixed ort value passing using the allocatir info

* fixed and coded maps and sequences across the abi

* cleaned up w4's
cleaned up the model info ABI
delayload directml.dll from winml
2019-11-27 15:04:47 -08:00
Tiago Koji Castro Shibata
9169c95a0e
Add CLI parameters to test runner, build WinML in ARM and x86 CI (#2479)
* Support test parameters through CLI arguments

* Add WinML do Windows x86/ARM CI builds

* Code style fixes

* Update googletest

Remove GPUTEST macros everywhere now that GTEST_SKIP is supported

* Refactor main.cpp

* Build scenario tests without DML
2019-11-27 10:33:00 -08:00
Brian Martin
0f9c6a530f
add missing IR version to 4 more models used by scenario tests (#2501) 2019-11-27 09:32:50 -08:00
Brian Martin
15acc7d349
fix one more missing IR version model (#2500) 2019-11-27 09:13:55 -08:00
Tiago Koji Castro Shibata
0688afa58f Rename ambiguous header (#2489) 2019-11-26 18:57:14 -08:00
Paul McDaniel
c27f56c38e
Layer dev paulm (#2492)
* commetns for dml graph transformer
fixed ort value passing using the allocatir info

* fixed and coded maps and sequences across the abi
2019-11-26 18:53:08 -08:00
Brian Martin
8346ddf222 fix bad model merge 2019-11-26 14:23:20 -08:00
Brian Martin
da24d9659f Merge branch 'windowsai' into layer_dev 2019-11-26 14:05:54 -08:00
Brian Martin
2394d16947
make api tests all pass (#2486) 2019-11-26 13:50:56 -08:00
Tiago Koji Castro Shibata
f40d5d80a0
Add scenario tests (#2457)
* Add scenario tests

* Remove TODO from model license

* Add winml_api test dependency
2019-11-25 17:17:23 -08:00
Brian Martin
34b1bf2db7
Brianma/testfails (#2473)
* add missing ir version to dictvectorizer-string.onnx

* add missing ir version to relu.onnx

* add missing ir version to zipmap*onnx

* add IR version to manually generated models

* remove an unnecessary ifdef dml
2019-11-25 14:38:19 -08:00
Paul McDaniel
befe933b86 build break. 2019-11-25 13:31:56 -08:00
Paul McDaniel
78c3c126c9 merged in brian's changes 2019-11-25 13:23:32 -08:00
Paul McDaniel
974ee0b74b Checking in a staging checkpoint point so that Ryan can work with me in parrallel 2019-11-25 12:50:04 -08:00
Brian Martin
3787a071c5
Brianma/fi (#2470)
* learning model doesn't need lotusEnvironment and CPU shouldn't include dmlEP headers

* User/xianz/win ml telemetry (#2410)

* add option to enable winml telemetry

* add option to enable winml telemetry

* clean logs while developping

* clean the log of GUID

* compile onnxruntime_common with winml telemetry

* use option for use_telemetry

* rename option winml_use_telemetry to onnxruntime_use_telemetry

* little change

* Add opset and IR check when loading model (#2413)

* Add opset and IR check.
* Add test case for future opsets.

https://github.com/microsoft/onnxruntime/issues/2371

* WinML CI (#2412)

* Pass flags to build/test WinML in CI

* Add initial CMake config for unit tests in WinML

* Set winml_unittests standard to C++17

* Add WinML API tests and port them to googletest

* Install WinML test collateral

* Add LearningModelSessionAPITests ported to googletest

* Fix WinML test files encoding

* Add GPU tests

* Add parameterized test, skip GPU tests

* Enable precompiled header

* Remove unused code and collateral

* Remove brand images

* Add dllload.cpp

* Remove images not used in API tests

* Add LICENSE.md to image collaterals

* Add models with licenses

* Remove FNS Candy tests

* Add API test models

* Add ModelInSubdirectory

* Install collaterals post-build with copy_if_different, split common lib

* fix warnings

* Link to gtest_main

* fix bad merge
2019-11-25 11:34:34 -08:00
Brian Martin
1bc2ca6183
Brianma/breaks (#2469)
* fix some more breaks

* learning model doesn't need lotusEnvironment and CPU shouldn't include dmlEP headers

* move dml checks out of winml and into the adapter

* better error handling
2019-11-25 11:11:30 -08:00
Brian Martin
d738bdd968
Brianma/cpuwinml (#2466)
* allow building winml cpu without dml.
2019-11-22 16:13:28 -08:00
Ryan Lai
0b5750d047
Register WinML TraceLogging provider on Onnxruntime.dll (#2455)
* Register WinML TraceLogging provider on Onnxruntime.dll

* Add ifdef to make sure trace logging provider has telemetry option when LAYERING_DONE

* No need for ifdef for TraceLoggingOptionMicrosoftTelemetry

* PR feedback

* Move etw registration into lotus environment constructor and deresgister in lotus environment destructor
2019-11-22 07:23:20 -08:00
Tiago Koji Castro Shibata
0f5f17c175
WinML CI (#2412)
* Pass flags to build/test WinML in CI

* Add initial CMake config for unit tests in WinML

* Set winml_unittests standard to C++17

* Add WinML API tests and port them to googletest

* Install WinML test collateral

* Add LearningModelSessionAPITests ported to googletest

* Fix WinML test files encoding

* Add GPU tests

* Add parameterized test, skip GPU tests

* Enable precompiled header

* Remove unused code and collateral

* Remove brand images

* Add dllload.cpp

* Remove images not used in API tests

* Add LICENSE.md to image collaterals

* Add models with licenses

* Remove FNS Candy tests

* Add API test models

* Add ModelInSubdirectory

* Install collaterals post-build with copy_if_different, split common lib

* fix warnings

* Link to gtest_main
2019-11-21 16:55:32 -08:00
Paul McDaniel
44a4fc0cc2 Moved SessionOptions over to the abi 2019-11-19 18:15:47 -08:00
Paul McDaniel
d8941f11b1 fixed map and sequence when passing stl types across the ABI .
found a leak in nvidia driver, but skipped it.
all winmlapitests pass now
2019-11-19 10:54:51 -08:00
Paul McDaniel
3da841bb73 fixed 2 more heap corruptions 2019-11-18 19:46:32 -08:00