Commit graph

7 commits

Author SHA1 Message Date
Scott McKay
5e0928a777
Enable running PEP8 on python scripts using flake8 (#3928)
* Enable running PEP8 checks via flake8 as part of the build if flake8 is installed.
Update scripts in \tools and \onnxruntime\python. Excluding \onnxruntime\python\tools which needs a lot more work to be PEP8 compliant. Also excluding orttraining\tools for the same reason.
Install flake8 as part of the static_analysis build task in the Win-CPU CI so the checks are run in one CI build.
Update coding standards doc.
2020-05-15 07:15:06 +10:00
Scott McKay
932ecaea34
Some documentation updates. (#3060) 2020-02-21 20:07:39 +10:00
Pranav Sharma
f13b66768a
Fix build for gcc 4.8.5. (#2036) 2019-10-08 00:50:53 -07:00
Pranav Sharma
7c5b3a5ecc
Update coding guidelines to prefer using make_unique for heap allocations (unless where not possible). (#1730)
* Mention OrtCreateSessionFromArray in C API doc

* Fix perf test executable due to removal of certain C APIs

* fix linux build

* Avoid duplication

* Update coding guidelines to prefer using make_unique for heap allocations (unless where not possible).
2019-09-04 19:16:16 -07:00
Changming Sun
051ee681a3
Add a few suggestions to coding guideline (#1238)
* Add a few suggestions to coding guideline
2019-06-18 19:28:21 -07:00
Scott McKay
4a8d75386b
Clarify/state expected usage of non-const references and 'auto' in coding conventions (#1096)
* As we consistently use non-const reference for modifiable arguments that cannot be null, update the conventions to reflect that.

Add a note on qualifying 'auto' to make the intent clearer and it easier to notice accidental copies.

* Address PR comment by adding a statement around disabling copy/assignment/move for new classes until needed.
2019-05-23 19:28:01 -07:00
Pranav Sharma
89618e8f1e Initial bootstrap commit. 2018-11-19 16:48:22 -08:00