Commit graph

7863 commits

Author SHA1 Message Date
Vincent Wang
506060dc37
Remove Useless Cast from Contiguous Cast Nodes (#5204)
* remove useless cast

* move the optimization to cast transformer

* bugfix

* resolve comments

* fix comment

Co-authored-by: Vincent Wang <weicwang@microsoft.com>
2020-09-29 09:18:52 +08:00
Changming Sun
d45d68fdd4
Fix a memory leak in our testing code (#5312) 2020-09-28 16:00:57 -07:00
Scott McKay
3693f91218
Update doc to be explicit about backwards compatibility. (#5309) 2020-09-29 07:34:49 +10:00
ytaous
b18a8bc74f
Transpose kernel fix for illegal memory access error (#5294)
* transpose fix

* minor update per comments

Co-authored-by: Ethan Tao <ettao@microsoft.com>
2020-09-28 13:59:50 -07:00
Changming Sun
1a04b8f8b7
Add valgrind support to our cmake files (#5296) 2020-09-28 09:31:08 -07:00
Guoyu Wang
fec890a09a
fix build break (#5306) 2020-09-28 00:10:48 -07:00
RRRachelllll555
507f5bf5f6
Update test calibrate script (#5185)
* update test_calibrate according to latest calibrate.py

* fix datasize bug in e2e example

Co-authored-by: t-yguo <t-yguo@microsoft.com>
2020-09-27 21:59:56 -07:00
Tang, Cheng
d9ecc0cebf
add bert loss legacy back (#5224) 2020-09-27 13:41:16 -07:00
George Wu
16d35266ab
add install targets for ep shared libs (#5286) 2020-09-25 07:10:43 -07:00
Guoyu Wang
3a3f26f38e
Move ort flatbuffers helper functions and value info r/w functions into separated lib (#5276)
* Move fbs include from header to cc

* add initial cmake for flatbuffers

* Move most flatbuffers util to ort_flatbuffers

* move code around

* fix

* move test/perf runner to use flatbuffer directly instead of model

* minor update

* Fix build break

* Clean up includes and foward decl

* Fix traning CI build breaks

* Addressed PR comment, replaced some include with forward decls

* Remove ORT_MUST_USE_RESULT temporarily
2020-09-25 05:36:29 -07:00
ISS Build Account
098f6b9069 Merge remote-tracking branch 'upstream/master' into DmlDev 2020-09-25 12:29:28 +00:00
Changming Sun
17f1178c2e
Downgrade GCC (#5269)
Co-authored-by: Edward Chen <18449977+edgchen1@users.noreply.github.com>
2020-09-24 21:14:54 -07:00
Sherlock
b03fb82ab7
Transformer layer-wise Recompute (#4526)
* Build Recomputation Graph

* Make topological sort to run FW nodes first

* Pattern match start and end of transformer layer

* Topological sort with Priority

* Add logger to Gradient Graph Builder

* Use Logger

* Introduce Execution Order
2020-09-24 19:56:32 -07:00
ISS Build Account
c2c30285cd Merge remote-tracking branch 'upstream/master' into DmlDev 2020-09-25 01:28:16 +00:00
Faith Xu
b6e71200eb
Add additional tutorial links (#5272) 2020-09-24 17:27:58 -07:00
Dmitri Smirnov
89742411ec
Insert telemetry template into GPU build, add telemry build switches. (#5278) 2020-09-24 17:13:09 -07:00
Thiago Crepaldi
ebeeff22dd
Update PyTorch TransformerModel sample (#5275) 2020-09-24 16:28:07 -07:00
Ryan Lai
71b52ad5de
Fix inbox telemetry (#5265)
* ifdef to check if redist or not

* Fix redist telemetry

Co-authored-by: Ryan Lai <ryalai96@gamil.com>
2020-09-24 14:58:07 -07:00
Scott McKay
b49ff6151e
Workaround issue with VS2017 compiler. (#5279)
The definitions for some Eigen classes don't get pulled in leading to errors. Split out the broadcast function creation logic from the functions using std::enable_if to workaround that.
2020-09-25 06:50:14 +10:00
KeDengMS
5a71819be6
Symbolic shape inference: fix a case for concat (#5277)
* Symbolic shape inference: fix a case when concat requires merge multiple dims

* Fix a bug triggered in newer version of sympy
Fix a bug in output data type guessing
2020-09-24 08:16:47 -07:00
Josh Bradley
4ed31ca214
Combine custom logger global threadpools (#4857)
* add custom logger and global threadpools to C and C++ API

* code cleanup and formatting

* reformat code

* tidy up some more code formatting

* remove comment

* fix API break from merging from master

* renamed API function to CreateEnvWithCustomLoggerAndGlobalThreadPools

* rename log variable and apply clang-format
2020-09-24 00:50:26 -07:00
Dwayne Robinson
6ad39819c2
Update DirectML Nuget to 1.3.0 (#5274)
Update to 1.3.0
2020-09-23 22:53:02 -07:00
Dwayne Robinson
a4cb00b91e
Merge pull request #5273 from microsoft/user/dwayner/CmakeLinkerOptFlags
Linker opt flags - fix conflicting CMake linker flags which contradict those needed by the Windows inbox universal CRT
2020-09-23 20:08:21 -07:00
edgchen1
6d5b93b805
Synchronize training dependency versions between Docker image and Python wheel. (#5261)
Synchronize training dependency versions between Docker image and wheel, update docs, refactor build scripts.
2020-09-23 19:03:42 -07:00
Justin Stoecker
56862f4022 Add way to disable additional linker opt flags 2020-09-23 12:56:40 -07:00
Ashwini Khade
16220f3848
Add FusedMatMul contrib op (#5213)
* bug fix transformer

* fuse cpu kernel for transposescalematmul and matmul

* fuse transpose_scale_matmul cpu kernel with matmul

* fix test

* Add FusedMatMul Contrib Op

* fix test

* fix typo

* plus more updates per review
2020-09-23 12:17:50 -07:00
Guoyu Wang
fe7e7bfe60
Update build.md for building using Xcode 12 on Mac (#5256)
* update build.md

* update build.md

* Address pr comments
2020-09-23 09:23:35 -07:00
Yufeng Li
61ba5b501a
Fix bug in the back to back quantization of matmul and conv (#5264)
* fix bug in the back to back quantization of matmul and conv

* fix bug in back to back gather
2020-09-23 08:47:20 -07:00
George Wu
b5a6a8e847
remove implicit linking of tensorrt and dnnl ep shared libs (#5262)
* remove trt and dnnl from link command

* add comment
2020-09-23 05:47:18 -07:00
Dwayne Robinson
6ea66b43db
ORT DirectML EP for Iron release, ONNX 1.5 (part 2) (#5263)
* Merged PR 5195856: Fix broken cases of zero size tensors in Cast/Reduce

 MaskRCNN failed when `Cast` tried to execute `Xor` with emptiness (zero in dimensions). This is perfectly legal and should be treated as a nop.

Ultimately DML itself should treat this case as a nop, just like how C's `memcpy` treats 0 count as a nop, but I'm just addressing it in ORT now, as enabling it in DML would impact more operators to be consistent (probably should incrementally add a flag to tensor validation so operators can be opted in gradually).

Corresponding WindowsAI PR: https://microsoft.visualstudio.com/WindowsAI/_git/WindowsAI/pullrequest/5195850

Related work items: #27469839, #28761382

* Merged PR 5201369: Remove copy of initializers added in DMLXP refactor

When used in ORT, a common method shouldn't copy and return initializer data

Related work items: #29514403

Co-authored-by: Justin Stoecker <justoeck@microsoft.com>
Co-authored-by: Jeff Bloomfield <jeffbloo@microsoft.com>
2020-09-23 01:56:19 -07:00
Hariharan Seshadri
75d994f194
Handle zero norm values in LpNormalization CPU kernel (#5251) 2020-09-22 22:01:09 -07:00
Adam Pocock
d26c71f55c
[java] Fixing the buffer semantics. (#5223)
* [java] Fixing the buffer semantics.
* Renaming bufferCapacity to bufferRemaining.
* Adding a cast to char* so the pointer arithmetic works on Windows.
2020-09-22 21:29:01 -07:00
Scott McKay
c52561d044
Rework broadcasting setup to decrease binary size. (#5227)
* Rework broadcasting setup to decrease binary size. Push all the type specific down and separate out the broadcasting/parallelization.

Reductions:
element_wise_ops: 521.0KB -> 268.8KB
where: 25.8 KB -> 17.3 KB
qlinear_binary_op: 28.1 -> 12.8
2020-09-23 14:15:40 +10:00
Changming Sun
43faf9e388
Disable a few tests that run too long(1 hour) in debug mode (#5257) 2020-09-22 21:06:24 -07:00
Tianlei Wu
3bbce69185
bump version to 1.5.1 (#5258) 2020-09-22 20:57:34 -07:00
Jeff Bloomfield
59e69bf35b
Handle missing initializers in allocation planner to fix crashes with DML provider (#5244)
* Fix memory planning bug with DML EP

* Address PR comments

* Fix typo
2020-09-22 19:37:07 -07:00
Jeff Bloomfield
682ac275fb Merged PR 5201369: Remove copy of initializers added in DMLXP refactor
When used in ORT, a common method shouldn't copy and return initializer data

Related work items: #29514403
2020-09-22 19:27:23 -07:00
Justin Stoecker
9d57bb4ba7 Add way to disable additional linker opt flags 2020-09-22 19:08:56 -07:00
Dwayne Robinson
ed5665758c Merged PR 5195856: Fix broken cases of zero size tensors in Cast/Reduce
MaskRCNN failed when `Cast` tried to execute `Xor` with emptiness (zero in dimensions). This is perfectly legal and should be treated as a nop.

Ultimately DML itself should treat this case as a nop, just like how C's `memcpy` treats 0 count as a nop, but I'm just addressing it in ORT now, as enabling it in DML would impact more operators to be consistent (probably should incrementally add a flag to tensor validation so operators can be opted in gradually).

Corresponding WindowsAI PR: https://microsoft.visualstudio.com/WindowsAI/_git/WindowsAI/pullrequest/5195850

Related work items: #27469839, #28761382
2020-09-22 19:08:28 -07:00
Ye Wang
898531f502
Fix reshape fusion crash (#5252)
* fix reshape fusion crash

* handling start_node statelessly

* fix
2020-09-22 15:04:13 -07:00
Guoyu Wang
e30530d9ea
Add java API for AddSessionConfigEntry (#5241)
* Add session option config entry API for java

* Java format

* Add extra test verification

* Address PR comments

* Update comments

Co-authored-by: gwang0000 <62914304+gwang0000@users.noreply.github.com>
2020-09-22 14:51:39 -07:00
KeDengMS
8dceebda0e
[Training/Python] Add option to enable symbolic shape inference (#5107)
This change adds symbolic shape inference to ORT training which helps static memory planning for model like BART.
2020-09-22 10:49:07 -07:00
edgchen1
14f250a4d0
Update BUILD.md training dependency info. (#5240)
Update training dependency versions based on Dockerfile.training.
2020-09-22 10:36:04 -07:00
Guoyu Wang
d957dbebea
Fix possible ios build break after update to Xcode 12 (#5246)
* Fix possible ios build break after update to Xcode 12

* Address comments
2020-09-22 07:42:54 -07:00
suffian khan
417929b049 jobs timeout .. 2020-09-21 21:51:59 -07:00
suffian khan
a6eb90472c try fix error on code coverage ci build 2020-09-21 21:51:59 -07:00
Sherlock
1478643215
Place Shape's output in CPU memory (#5245)
Co-authored-by: Sherlock Huang <bahuang@OrtTrainingDev3.af05slrtruoetgaxwwjv5nsq5e.px.internal.cloudapp.net>
2020-09-21 20:21:59 -07:00
Sherlock
038192bdb2
Place shape related compute nodes in CPU (#4940)
* Place shape related nodes in CPU
* visit candidates by topological order
* Make CPU node placement a utility function
* skip placing on CPU if the data typs is float16 or bfloat16
2020-09-21 17:10:39 -07:00
Changming Sun
0cb09374c6
Update BUILD.md for CUDA versions (#5239) 2020-09-21 15:28:53 -07:00
George Wu
3147bc00c3
update TensorRT docs (#5238)
* doc updates TensorRT

* update

* update

* fix warning

* newline

* format
2020-09-21 15:24:20 -07:00