From fdd71574d6b360a3d472118f3d7856dde80ce07a Mon Sep 17 00:00:00 2001 From: Hariharan Seshadri Date: Mon, 11 Feb 2019 14:38:43 -0800 Subject: [PATCH] misc: Fix comment in op_node_proto_helper (#460) * Fix comment in op_node_proto_helper * PR feedback --- include/onnxruntime/core/framework/op_node_proto_helper.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/include/onnxruntime/core/framework/op_node_proto_helper.h b/include/onnxruntime/core/framework/op_node_proto_helper.h index 492dd09ed2..6df3d7ea50 100644 --- a/include/onnxruntime/core/framework/op_node_proto_helper.h +++ b/include/onnxruntime/core/framework/op_node_proto_helper.h @@ -37,13 +37,14 @@ class OpNodeProtoHelper { /** Get a single attribute + Call this function for a required attribute or when a default value for an optional attribute is specified in the op schema */ template MUST_USE_RESULT Status GetAttr(const std::string& name, T* value) const; /** Get a single attribute - Call this function only when onnx doesn't have default value + Call this function only when a default value for an optional attribute isn't specified in the op schema */ template T GetAttrOrDefault(const std::string& name, const T& default_value) const { @@ -53,7 +54,7 @@ class OpNodeProtoHelper { /** Get a single attribute - Call this function only when onnx doesn't have default value + Call this function only when a default value for an optional attribute isn't specified in the op schema */ template void GetAttrOrDefault(const std::string& name, T* value, const T& default_value) const { @@ -63,7 +64,7 @@ class OpNodeProtoHelper { /** Get repeated attributes - Call this function only when onnx doesn't have default value + Call this function only when a default value for an optional attribute isn't specified in the op schema */ template MUST_USE_RESULT std::vector GetAttrsOrDefault(const std::string& name, const std::vector& default_value = std::vector{}) const {