saymrwulf/onnxruntime
1
0
Fork 0
mirror of https://github.com/saymrwulf/onnxruntime.git synced 2026-05-18 21:21:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Provide kwargs to remove_shared_initializers (#17539)

Browse source 
### Description
Fixes a bug in `get_shared_initializers` where `signature_cache1,
signature_cache2` are passed as positional arguments to
`remove_shared_initializers` but their positions don't match the
function signature. So `signature_cache1` is passed to `min_elements`
and causes comparison error at line 907.

Pass the arguments as kwargs so that it doesn't rely on their positions.


### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
Fixes the bug described above.
This commit is contained in:
Jambay Kinley 2023-09-18 16:41:11 -07:00 committed by GitHub
parent 7116e66c4b
commit f969e7f8d8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
onnxruntime/python/tools/transformers/convert_generation.py
View file

@ -993,7 +993,11 @@ def get_shared_initializers(encoder_model: ModelProto, decoder_model: ModelProto
encoder.remove_duplicated_initializer(signature_cache1)
decoder.remove_duplicated_initializer(signature_cache2)
initializers = remove_shared_initializers(
decoder.model.graph, encoder.model.graph, "s_", signature_cache1, signature_cache2
decoder.model.graph,
encoder.model.graph,
shared_prefix="s_",
signature_cache1=signature_cache1,
signature_cache2=signature_cache2,
)
return initializers