From f7cabf6d4c92be969817acebcf2507738c7b9f5d Mon Sep 17 00:00:00 2001 From: Justin Chu Date: Fri, 1 Nov 2024 13:13:04 -0700 Subject: [PATCH] Use suggest-changes@v2 (#22667) Use suggest-changes@v2 (https://github.com/parkerbxyz/suggest-changes/issues/36#issuecomment-2447605058) to post suggested changes as comments instead of requested changes to streamline the review process. - Also updated the script to `set +e` to ignore exit code only for the linter run. So that if there is errors in dependency installation we can still get signals. --- .github/workflows/pr_checks.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/pr_checks.yml b/.github/workflows/pr_checks.yml index af3f00c4e3..af890d8899 100644 --- a/.github/workflows/pr_checks.yml +++ b/.github/workflows/pr_checks.yml @@ -41,12 +41,12 @@ jobs: - name: Install dependencies and run lintrunner on all files run: | - set -e python -m pip install --user -r requirements-dev.txt - python -m pip install --user lintrunner lintrunner-adapters + python -m pip install --user lintrunner lintrunner-adapters lintrunner init + set +e lintrunner f --all-files -v exit 0 - - uses: parkerbxyz/suggest-changes@v1 + - uses: parkerbxyz/suggest-changes@v2 with: comment: 'You can commit the suggested changes from lintrunner.'