saymrwulf/onnxruntime
1
0
Fork 0
mirror of https://github.com/saymrwulf/onnxruntime.git synced 2026-07-29 20:14:01 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix overflow causing test failure on x86 (#20425)

Browse source 
### Description
<!-- Describe your changes. -->
Fix comparison that was not updated when the threshold was converted to
bytes.


### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
Fix CI failure
This commit is contained in:
Scott McKay 2024-04-23 21:33:59 +10:00 committed by GitHub
parent 5eae33fc6b
commit ed6f1adcb8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
orttraining/orttraining/training_api/checkpoint.cc
View file

@ -301,7 +301,7 @@ Status FromTensorProtos(gsl::span<const ONNX_NAMESPACE::TensorProto> trainable_t
fbs_buffer_size = std::max(fbs_buffer_size, m_bytes);
fbs_buffer_size = ((fbs_buffer_size + m_bytes - 1) / m_bytes) * m_bytes;
const bool use_external_data = fbs_buffer_size >= external_data_threshold * m_bytes;
const bool use_external_data = fbs_buffer_size >= external_data_threshold;
fbs::utils::ExternalDataWriter external_data_writer = nullptr;
std::optional<std::ofstream> external_data_stream;