saymrwulf/onnxruntime
1
0
Fork 0
mirror of https://github.com/saymrwulf/onnxruntime.git synced 2026-07-30 20:18:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add another input validation to ReverseSequence (#7445)

Browse source 
* Add another input validation to ReverseSequence

* Limit the bad length test to the CPU EP
This commit is contained in:
Scott McKay 2021-04-30 07:24:32 +10:00 committed by GitHub
parent 994c2ed420
commit e255506bcd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 37 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
onnxruntime/core/providers/cpu/tensor/reverse_sequence.cc
View file

@ -139,8 +139,14 @@ static Status ReverseSequenceImpl(const Tensor& X,
for (int i = 0; i < batch_size; i++) {
int64_t seq_len = sequence_lengths[i];
if (seq_len == 0)
if (seq_len == 0) {
continue;
}
if (seq_len > max_seq_len || seq_len < 0) {
return ORT_MAKE_STATUS(ONNXRUNTIME, FAIL, "Invalid sequence length: ", seq_len,
". Value must be in range [0,", max_seq_len, "]");
}
for (int64_t j = 0; j < seq_len; j++) {
gsl::span<const T> src = inputs.subspan(input_offset(max_seq_len, batch_size, input_size, i, j), input_size);

30
onnxruntime/test/providers/cpu/tensor/reverse_sequence_test.cc
View file

@ -3,6 +3,7 @@
#include "gtest/gtest.h"
#include "test/providers/provider_test_utils.h"
#include "test/util/include/default_providers.h"
namespace onnxruntime {
namespace test {
@ -144,5 +145,34 @@ TEST(ReverseSequenceTest, InvalidInput) {
}
}
TEST(ReverseSequenceTest, BadLength) {
auto run_test = [](bool use_negative) {
OpTester test("ReverseSequence", 10);
std::vector<int64_t> input = {0, 1, 2, 3,
4, 5, 6, 7};
std::vector<int64_t> sequence_lens = {4, 3};
// make sequence_lens invalid for the input
sequence_lens[1] = use_negative ? -2 : 6;
test.AddAttribute("batch_axis", int64_t(0));
test.AddAttribute("time_axis", int64_t(1));
test.AddInput<int64_t>("input", {2, 4, 1}, input);
test.AddInput<int64_t>("sequence_lens", {2}, sequence_lens);
test.AddOutput<int64_t>("Y", {0}, {});
// the bad length check is just in the CPU EP
std::vector<std::unique_ptr<IExecutionProvider>> eps;
eps.push_back(DefaultCpuExecutionProvider());
test.Run(OpTester::ExpectResult::kExpectFailure, "Invalid sequence length", {}, nullptr, &eps);
};
run_test(true);
run_test(false);
}
} // namespace test
} // namespace onnxruntime