Docker image release build updates (#5326)

- Update docker image release build to use build commit.
- Use valid default in component governance detection step.
- Use smaller docker build context.
This commit is contained in:
edgchen1 2020-10-01 12:25:31 -07:00 committed by GitHub
parent fe50213491
commit d62873a331
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 10 deletions

View file

@ -1,8 +1,4 @@
parameters:
- name: commit
displayName: Commit (Default to master or use sha1)
type: string
default: master
- name: image_tag
displayName: Image Tag
type: string
@ -10,7 +6,8 @@ parameters:
variables:
docker_image_prefix: onnxruntime-training
linux_gpu_dockerfile: dockerfiles/Dockerfile.training
linux_gpu_dockerfile: '$(Build.SourcesDirectory)/dockerfiles/Dockerfile.training'
docker_build_context: '$(Build.SourcesDirectory)/dockerfiles'
build_config: Release
name: $(Date:yyyyMMdd)$(Rev:.r)
@ -30,9 +27,10 @@ jobs:
-t ${{ variables.docker_image_prefix }}-manylinux-gpu-release-stage1 \
--target builder \
--no-cache \
--build-arg COMMIT="${{ parameters.commit }}" \
--build-arg COMMIT="$(Build.SourceVersion)" \
--build-arg BUILD_CONFIG="${{ variables.build_config }}" \
-f ${{ variables.linux_gpu_dockerfile }} .
-f ${{ variables.linux_gpu_dockerfile }} \
${{ variables.docker_build_context }}
workingDirectory: $(Build.SourcesDirectory)
- task: CmdLine@2
@ -56,8 +54,9 @@ jobs:
command: build
containerRegistry: 'ortrelease'
repository: 'onnxruntime-training'
arguments: --build-arg COMMIT="${{ parameters.commit }}" --build-arg BUILD_CONFIG="${{ variables.build_config }}"
Dockerfile: ${{ variables.linux_gpu_dockerfile }}
arguments: --build-arg COMMIT="$(Build.SourceVersion)" --build-arg BUILD_CONFIG="${{ variables.build_config }}"
Dockerfile: '${{ variables.linux_gpu_dockerfile }}'
buildContext: '${{ variables.docker_build_context }}'
tags: |
$(Build.BuildNumber)
${{ parameters.image_tag }}

View file

@ -2,7 +2,7 @@
parameters:
- name: condition
type: string
default: '' # could be 'ci_only', 'always', 'succeeded'
default: 'succeeded' # could be 'ci_only', 'always', 'succeeded'
steps:
- task: ms.vss-governance-buildtask.governance-build-task-component-detection.ComponentGovernanceComponentDetection@0