From ca7985fd9fb481d0d87c49ac2ee4c1a6f44c0fee Mon Sep 17 00:00:00 2001 From: ytaous <4484531+ytaous@users.noreply.github.com> Date: Thu, 19 Mar 2020 10:40:00 -0700 Subject: [PATCH] Address PR comments (#3256) * comments * fix path * fix path Co-authored-by: Ethan Tao --- cmake/CMakeLists.txt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/cmake/CMakeLists.txt b/cmake/CMakeLists.txt index d0039e4a41..cae765b6c2 100644 --- a/cmake/CMakeLists.txt +++ b/cmake/CMakeLists.txt @@ -809,7 +809,10 @@ if (onnxruntime_ENABLE_TRAINING) set(HOROVOD_ROOT ${PROJECT_SOURCE_DIR}/external/horovod) set(HOROVOD_INCLUDE_DIRS "${HOROVOD_ROOT}/horovod/common" ${MPI_CXX_INCLUDE_PATH}) add_subdirectory(horovod EXCLUDE_FROM_ALL) - list(APPEND onnxruntime_EXTERNAL_LIBRARIES horovod /usr/lib/x86_64-linux-gnu/libnccl.so ${MPI_CXX_LIBRARIES} ${MPI_CXX_LINK_FLAGS}) + # use external/horovod/third_party/gloo/cmake/Modules/Findnccl.cmake to locate nccl lib path + list(APPEND CMAKE_MODULE_PATH ${PROJECT_SOURCE_DIR}/external/horovod/third_party/gloo/cmake/Modules/) + find_package(nccl REQUIRED) + list(APPEND onnxruntime_EXTERNAL_LIBRARIES horovod ${NCCL_LIBRARIES} ${MPI_CXX_LIBRARIES} ${MPI_CXX_LINK_FLAGS}) endif() endif()