From c08e5f55e9eabd4992f7ee5b33f70eb3560ad37f Mon Sep 17 00:00:00 2001 From: albertomagni-ms <49027342+albertomagni-ms@users.noreply.github.com> Date: Mon, 27 Jul 2020 22:42:58 +0100 Subject: [PATCH] Fix misleading indentation (#4629) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Adjust indentation of statement, without this fix GCC 7.5 errors out with: "this ‘if’ clause does not guard this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’" * Add braces around the if-statement for improved clarity. Co-authored-by: Alberto Magni --- orttraining/orttraining/training_ops/cpu/tensor/split.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/orttraining/orttraining/training_ops/cpu/tensor/split.cc b/orttraining/orttraining/training_ops/cpu/tensor/split.cc index 8332d58c0f..d14c10951c 100644 --- a/orttraining/orttraining/training_ops/cpu/tensor/split.cc +++ b/orttraining/orttraining/training_ops/cpu/tensor/split.cc @@ -49,15 +49,15 @@ Status PrepareForTrainingCompute(const TensorShape& input_shape, int num_outputs // populate split_sizes with the same size for each output split_sizes = std::vector(static_cast(num_outputs), split_dim_size / num_outputs); } else { - if (split_sizes_values.size() != static_cast(num_outputs) || split_size_sum != split_dim_size) + if (split_sizes_values.size() != static_cast(num_outputs) || split_size_sum != split_dim_size) { return ORT_MAKE_STATUS(ONNXRUNTIME, FAIL, "Cannot split using values in 'split' input. Axis=", axis_value, " Input shape=", input_shape, " NumOutputs=", num_outputs, " Num entries in 'split' (must equal number of outputs) was ", split_sizes_values.size(), " Sum of sizes in 'split' (must equal size of selected axis) was ", split_size_sum); - - split_sizes = split_sizes_values; + } + split_sizes = split_sizes_values; } return Status::OK();