From bbf28f09f2cb756a4ae02d511f77091a996fb812 Mon Sep 17 00:00:00 2001 From: Changming Sun Date: Thu, 31 Aug 2023 06:56:27 -0700 Subject: [PATCH] Fix a build warning: a constexpr function calls a non-constexpr function (#17363) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ### Description The warning is: ``` /onnxruntime_src/onnxruntime/core/optimizer/transpose_optimization/onnx_transpose_optimization.cc:1202:41: error: call to non-‘constexpr’ function ‘bool onnx_transpose_optimization::TransposeQuantizeDequantizeAxis(const onnx_transpose_optimization::api::GraphRef&, const std::vector&, onnx_transpose_optimization::api::NodeRef&)’ return TransposeQuantizeDequantizeAxis(graph, perm, node); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~ ``` The function TransposeQuantizeDequantizeAxis is not constexpr. \ --- .../transpose_optimization/onnx_transpose_optimization.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/onnxruntime/core/optimizer/transpose_optimization/onnx_transpose_optimization.cc b/onnxruntime/core/optimizer/transpose_optimization/onnx_transpose_optimization.cc index a6fa5ce358..3723ee6032 100644 --- a/onnxruntime/core/optimizer/transpose_optimization/onnx_transpose_optimization.cc +++ b/onnxruntime/core/optimizer/transpose_optimization/onnx_transpose_optimization.cc @@ -1192,8 +1192,8 @@ bool TransposeQuantizeDequantizeAxis(const api::GraphRef& graph, const std::vect return true; } -constexpr bool HandleQuantizeDequantizeAxis(const api::GraphRef& graph, const std::vector& perm, - api::NodeRef& node, int64_t opset) { +static bool HandleQuantizeDequantizeAxis(const api::GraphRef& graph, const std::vector& perm, + api::NodeRef& node, int64_t opset) { if (opset < 13) { // no `axis` value until opset 13 return true;