saymrwulf/onnxruntime
1
0
Fork 0
mirror of https://github.com/saymrwulf/onnxruntime.git synced 2026-07-10 17:37:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

[DML EP] Fix prefast warning in LayerNorm ops (#13889)

Browse source 
### Description
Fix prefast warning in LayerNorm ops



### Motivation and Context
Prefast complains that we should upcast before subtracting because
otherwise an overflow (or underflow) could happen. So we add these casts
to appease it.
This commit is contained in:
Patrice Vignola 2022-12-13 13:24:02 -08:00 committed by GitHub
parent 8246ff015a
commit 9dd593e18f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
onnxruntime/core/providers/dml/DmlExecutionProvider/src/Operators/DmlOperatorLayerNormalization.cpp
View file

@ -30,7 +30,7 @@ public:
int32_t onnxAxis = kernelCreationContext.GetOptionalAttribute<int32_t>(AttrName::Axis, -1);
uint32_t inputDimCount = kernelCreationContext.GetTensorShapeDescription().GetInputTensorDimensionCount(0);
onnxAxis = OperatorHelper::HandleNegativeAxis(onnxAxis, inputDimCount);
std::vector<uint32_t> onnxAxes(inputDimCount - onnxAxis);
std::vector<uint32_t> onnxAxes(static_cast<size_t>(inputDimCount) - static_cast<size_t>(onnxAxis));
std::iota(onnxAxes.begin(), onnxAxes.end(), onnxAxis);
assert(m_inputTensorDescs.size() == 3);

2
onnxruntime/core/providers/dml/DmlExecutionProvider/src/Operators/DmlOperatorSkipLayerNormalization.cpp
View file

@ -27,7 +27,7 @@ public:
int32_t onnxAxis = kernelCreationContext.GetOptionalAttribute<int32_t>(AttrName::Axis, -1);
uint32_t inputDimCount = kernelCreationContext.GetTensorShapeDescription().GetInputTensorDimensionCount(0);
onnxAxis = OperatorHelper::HandleNegativeAxis(onnxAxis, inputDimCount);
std::vector<uint32_t> onnxAxes(inputDimCount - onnxAxis);
std::vector<uint32_t> onnxAxes(static_cast<size_t>(inputDimCount) - static_cast<size_t>(onnxAxis));
std::iota(onnxAxes.begin(), onnxAxes.end(), onnxAxis);
assert(m_inputTensorDescs.size() == 5);