[js/web] fix lint error when run without ort-web TS types (#10429)

* [js/web] fix lint error when run without ort-web TS types

* update CI to run linter before 'npm ci' in /js/web
This commit is contained in:
Yulong Wang 2022-02-17 22:34:38 -08:00 committed by GitHub
parent 1af4c170ef
commit 893ee65e54
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 4 deletions

View file

@ -10,7 +10,7 @@ import {initializeWebAssembly} from '../wasm-factory';
self.onmessage = (ev: MessageEvent<OrtWasmMessage>): void => {
switch (ev.data.type) {
case 'init-wasm':
initializeWebAssembly(ev.data.in!)
initializeWebAssembly(ev.data.in)
.then(
() => postMessage({type: 'init-wasm'} as OrtWasmMessage),
err => postMessage({type: 'init-wasm', err} as OrtWasmMessage));

View file

@ -99,7 +99,7 @@ if (WASM) {
}
fs.writeFileSync(WASM_BINDING_THREADED_MIN_JS_PATH, terser.stdout);
fs.writeFileSync(WASM_THREADED_JS_PATH, COPYRIGHT_BANNER + terser.stdout);
fs.writeFileSync(WASM_THREADED_JS_PATH, `${COPYRIGHT_BANNER}${terser.stdout}`);
validateFile(WASM_BINDING_THREADED_MIN_JS_PATH);
validateFile(WASM_THREADED_JS_PATH);
@ -124,7 +124,7 @@ if (WASM) {
}
fs.writeFileSync(WASM_BINDING_THREADED_MIN_WORKER_JS_PATH, terser.stdout);
fs.writeFileSync(WASM_THREADED_WORKER_JS_PATH, COPYRIGHT_BANNER + terser.stdout);
fs.writeFileSync(WASM_THREADED_WORKER_JS_PATH, `${COPYRIGHT_BANNER}${terser.stdout}`);
validateFile(WASM_BINDING_THREADED_MIN_WORKER_JS_PATH);
validateFile(WASM_THREADED_WORKER_JS_PATH);

View file

@ -72,6 +72,10 @@ jobs:
npm ci
workingDirectory: '$(Build.SourcesDirectory)\js'
displayName: 'npm ci /js/'
- script: |
npm run lint
workingDirectory: '$(Build.SourcesDirectory)\js'
displayName: 'run ESLint without TS type populated'
- script: |
npm ci
workingDirectory: '$(Build.SourcesDirectory)\js\common'
@ -83,7 +87,7 @@ jobs:
- script: |
npm run lint
workingDirectory: '$(Build.SourcesDirectory)\js'
displayName: 'ESLint'
displayName: 'run ESLint'
- script: |
npm run format
workingDirectory: '$(Build.SourcesDirectory)\js'