diff --git a/docs/How_To_Update_ONNX_Dev_Notes.md b/docs/How_To_Update_ONNX_Dev_Notes.md index 18f2c29f40..c1d1f634b4 100644 --- a/docs/How_To_Update_ONNX_Dev_Notes.md +++ b/docs/How_To_Update_ONNX_Dev_Notes.md @@ -12,24 +12,24 @@ git add onnx ``` (Change the to yours. If you are not sure, use 'origin/master'. Like 'git reset --hard origin/master') -2. Update [cgmanifests/generated/cgmanifest.json](/cgmanifests/generated/cgmanifest.json). +1. Update [cgmanifests/generated/cgmanifest.json](/cgmanifests/generated/cgmanifest.json). This file should be generated. See [cgmanifests/README](/cgmanifests/README.md) for instructions. -3. Update [tools/ci_build/github/linux/docker/scripts/requirements.txt](/tools/ci_build/github/linux/docker/scripts/requirements.txt) and [tools/ci_build/github/linux/docker/scripts/manylinux/requirements.txt](/tools/ci_build/github/linux/docker/scripts/manylinux/requirements.txt). +1. Update [tools/ci_build/github/linux/docker/scripts/requirements.txt](/tools/ci_build/github/linux/docker/scripts/requirements.txt) and [tools/ci_build/github/linux/docker/scripts/manylinux/requirements.txt](/tools/ci_build/github/linux/docker/scripts/manylinux/requirements.txt). Update the commit hash for `git+http://github.com/onnx/onnx.git@targetonnxcommithash#egg=onnx`. -4. If there is any change to `cmake/external/onnx/onnx/*.in.proto`, you need to re-regenerate OnnxMl.cs. Please build onnxruntime on Windows with csharp enabled, then the file will be auto-updated. +1. If there is any change to `cmake/external/onnx/onnx/*.in.proto`, you need to regenerate OnnxMl.cs. [Building onnxruntime with Nuget](https://onnxruntime.ai/docs/build/inferencing.html#build-nuget-packages) will do this. -6. If you are updating ONNX from a released tag to a new commit, please tell Changming deploying the new test data along with other test models to our CI build machines. This is to ensure that our tests cover every ONNX opset. +1. If you are updating ONNX from a released tag to a new commit, please tell Changming deploying the new test data along with other test models to our CI build machines. This is to ensure that our tests cover every ONNX opset. -5. Send you PR, and **manually** queue a build for every packaging pipeline for your branch. +1. Send you PR, and **manually** queue a build for every packaging pipeline for your branch. -6. If there is a build failure in stage "Check out of dated documents" in WebAssembly CI pipeline, update ONNX Runtime Web WebGL operator support document: +1. If there is a build failure in stage "Check out of dated documents" in WebAssembly CI pipeline, update ONNX Runtime Web WebGL operator support document: - Make sure Node.js is installed (see [Prerequisites](../js/README.md#Prerequisites) for instructions). - Follow step 1 in [js/Build](../js/README.md#Build-2) to install dependencies). - Follow instructions in [Generate document](../js/README.md#Generating-Document) to update document. Commit changes applied to file `docs/operators.md`. -7. Usually there would be some unitest failures, because you introduced new test cases. Then you may need to update +1. Usually there would be some unitest failures, because you introduced new test cases. Then you may need to update - [onnxruntime/test/onnx/main.cc](/onnxruntime/test/onnx/main.cc) - [onnxruntime/test/providers/cpu/model_tests.cc](/onnxruntime/test/providers/cpu/model_tests.cc) - [csharp/test/Microsoft.ML.OnnxRuntime.Tests/InferenceTest.cs](/csharp/test/Microsoft.ML.OnnxRuntime.Tests/InferenceTest.cs)