From 5972ce5566fc270db590145ab5218a4b5c973053 Mon Sep 17 00:00:00 2001 From: Dwayne Robinson Date: Fri, 27 Mar 2020 19:32:47 -0700 Subject: [PATCH] PR feedback --- .../dml/DmlExecutionProvider/src/ExecutionProvider.cpp | 9 +++++---- .../dml/OperatorAuthorHelper/OperatorHelper.cpp | 4 ++-- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/onnxruntime/core/providers/dml/DmlExecutionProvider/src/ExecutionProvider.cpp b/onnxruntime/core/providers/dml/DmlExecutionProvider/src/ExecutionProvider.cpp index 630e3bd3d8..04c6ef202c 100644 --- a/onnxruntime/core/providers/dml/DmlExecutionProvider/src/ExecutionProvider.cpp +++ b/onnxruntime/core/providers/dml/DmlExecutionProvider/src/ExecutionProvider.cpp @@ -500,11 +500,12 @@ namespace Dml std::string partitionKernelPrefix = std::to_string(m_partitionKernelPrefixVal++) + "_"; uint32_t deviceDataTypeMask = GetSuppportedDeviceDataTypeMask(); - return PartitionGraph(graph, + return PartitionGraph( + graph, *m_internalRegInfoMap, - registries, - deviceDataTypeMask, - m_kernelRegistry.get(), + registries, + deviceDataTypeMask, + m_kernelRegistry.get(), partitionKernelPrefix ); } diff --git a/onnxruntime/core/providers/dml/OperatorAuthorHelper/OperatorHelper.cpp b/onnxruntime/core/providers/dml/OperatorAuthorHelper/OperatorHelper.cpp index 92404fce16..0f905f6cd1 100644 --- a/onnxruntime/core/providers/dml/OperatorAuthorHelper/OperatorHelper.cpp +++ b/onnxruntime/core/providers/dml/OperatorAuthorHelper/OperatorHelper.cpp @@ -155,14 +155,14 @@ namespace OperatorHelper memcpy(data, tensor.GetByteData(), elementByteSize); } - int64_t ReadScalarTensorAsInt64(const MLOperatorTensor& tensor) + int64_t ReadScalarTensorCastToInt64(const MLOperatorTensor& tensor) { std::byte tensorBytes[8]; ReadScalarTensorData(tensor, /*out*/ &tensorBytes, sizeof(tensorBytes)); return CastToInt64(tensor.GetTensorDataType(), &tensorBytes); } - double ReadScalarTensorAsFloat64(const MLOperatorTensor& tensor) + double ReadScalarTensorCastToFloat64(const MLOperatorTensor& tensor) { std::byte tensorBytes[8]; ReadScalarTensorData(tensor, /*out*/ &tensorBytes, sizeof(tensorBytes));