From 546d8f71abb966f79f94f61ef04154b5f81e61ec Mon Sep 17 00:00:00 2001 From: Maher Jendoubi Date: Mon, 27 Jan 2020 22:39:08 +0100 Subject: [PATCH] Contributing: fix typos (#2905) --- .../Microsoft.ML.OnnxRuntime.Tests.csproj | 2 +- .../Microsoft.ML.OnnxRuntime.Tests/OnnxMl.cs | 2 +- java/src/test/java/ai/onnxruntime/OnnxMl.java | 36 +++++++++---------- .../src/DmlCommandRecorder.cpp | 2 +- server/test/integration_tests/README.MD | 2 +- 5 files changed, 22 insertions(+), 22 deletions(-) diff --git a/csharp/test/Microsoft.ML.OnnxRuntime.Tests/Microsoft.ML.OnnxRuntime.Tests.csproj b/csharp/test/Microsoft.ML.OnnxRuntime.Tests/Microsoft.ML.OnnxRuntime.Tests.csproj index 04c8a1cffa..bb062aa075 100644 --- a/csharp/test/Microsoft.ML.OnnxRuntime.Tests/Microsoft.ML.OnnxRuntime.Tests.csproj +++ b/csharp/test/Microsoft.ML.OnnxRuntime.Tests/Microsoft.ML.OnnxRuntime.Tests.csproj @@ -14,7 +14,7 @@ 7.2 True - true + true false ..\..\OnnxRuntime.snk diff --git a/csharp/test/Microsoft.ML.OnnxRuntime.Tests/OnnxMl.cs b/csharp/test/Microsoft.ML.OnnxRuntime.Tests/OnnxMl.cs index 57df68e12e..2d257177c4 100644 --- a/csharp/test/Microsoft.ML.OnnxRuntime.Tests/OnnxMl.cs +++ b/csharp/test/Microsoft.ML.OnnxRuntime.Tests/OnnxMl.cs @@ -311,7 +311,7 @@ namespace Onnx { /// implementations needed to use has_field hueristics to determine /// which value field was in use. For IR_VERSION 0.0.2 or later, this /// field MUST be set and match the f|i|s|t|... field in use. This - /// change was made to accomodate proto3 implementations. + /// change was made to accommodate proto3 implementations. /// [global::System.Diagnostics.DebuggerNonUserCodeAttribute] public global::Onnx.AttributeProto.Types.AttributeType Type { diff --git a/java/src/test/java/ai/onnxruntime/OnnxMl.java b/java/src/test/java/ai/onnxruntime/OnnxMl.java index 94ba78a32b..808c07b26b 100644 --- a/java/src/test/java/ai/onnxruntime/OnnxMl.java +++ b/java/src/test/java/ai/onnxruntime/OnnxMl.java @@ -424,10 +424,10 @@ public final class OnnxMl { *
      * The type field MUST be present for this version of the IR.
      * For 0.0.1 versions of the IR, this field was not defined, and
-     * implementations needed to use has_field hueristics to determine
+     * implementations needed to use has_field heuristics to determine
      * which value field was in use.  For IR_VERSION 0.0.2 or later, this
      * field MUST be set and match the f|i|s|t|... field in use.  This
-     * change was made to accomodate proto3 implementations.
+     * change was made to accommodate proto3 implementations.
      * 
* * .onnx.AttributeProto.AttributeType type = 20; @@ -437,10 +437,10 @@ public final class OnnxMl { *
      * The type field MUST be present for this version of the IR.
      * For 0.0.1 versions of the IR, this field was not defined, and
-     * implementations needed to use has_field hueristics to determine
+     * implementations needed to use has_field heuristics to determine
      * which value field was in use.  For IR_VERSION 0.0.2 or later, this
      * field MUST be set and match the f|i|s|t|... field in use.  This
-     * change was made to accomodate proto3 implementations.
+     * change was made to accommodate proto3 implementations.
      * 
* * .onnx.AttributeProto.AttributeType type = 20; @@ -1362,10 +1362,10 @@ public final class OnnxMl { *
      * The type field MUST be present for this version of the IR.
      * For 0.0.1 versions of the IR, this field was not defined, and
-     * implementations needed to use has_field hueristics to determine
+     * implementations needed to use has_field heuristics to determine
      * which value field was in use.  For IR_VERSION 0.0.2 or later, this
      * field MUST be set and match the f|i|s|t|... field in use.  This
-     * change was made to accomodate proto3 implementations.
+     * change was made to accommodate proto3 implementations.
      * 
* * .onnx.AttributeProto.AttributeType type = 20; @@ -1377,10 +1377,10 @@ public final class OnnxMl { *
      * The type field MUST be present for this version of the IR.
      * For 0.0.1 versions of the IR, this field was not defined, and
-     * implementations needed to use has_field hueristics to determine
+     * implementations needed to use has_field heuristics to determine
      * which value field was in use.  For IR_VERSION 0.0.2 or later, this
      * field MUST be set and match the f|i|s|t|... field in use.  This
-     * change was made to accomodate proto3 implementations.
+     * change was made to accommodate proto3 implementations.
      * 
* * .onnx.AttributeProto.AttributeType type = 20; @@ -2881,10 +2881,10 @@ public final class OnnxMl { *
        * The type field MUST be present for this version of the IR.
        * For 0.0.1 versions of the IR, this field was not defined, and
-       * implementations needed to use has_field hueristics to determine
+       * implementations needed to use has_field heuristics to determine
        * which value field was in use.  For IR_VERSION 0.0.2 or later, this
        * field MUST be set and match the f|i|s|t|... field in use.  This
-       * change was made to accomodate proto3 implementations.
+       * change was made to accommodate proto3 implementations.
        * 
* * .onnx.AttributeProto.AttributeType type = 20; @@ -2896,10 +2896,10 @@ public final class OnnxMl { *
        * The type field MUST be present for this version of the IR.
        * For 0.0.1 versions of the IR, this field was not defined, and
-       * implementations needed to use has_field hueristics to determine
+       * implementations needed to use has_field heuristics to determine
        * which value field was in use.  For IR_VERSION 0.0.2 or later, this
        * field MUST be set and match the f|i|s|t|... field in use.  This
-       * change was made to accomodate proto3 implementations.
+       * change was made to accommodate proto3 implementations.
        * 
* * .onnx.AttributeProto.AttributeType type = 20; @@ -2913,10 +2913,10 @@ public final class OnnxMl { *
        * The type field MUST be present for this version of the IR.
        * For 0.0.1 versions of the IR, this field was not defined, and
-       * implementations needed to use has_field hueristics to determine
+       * implementations needed to use has_field heuristics to determine
        * which value field was in use.  For IR_VERSION 0.0.2 or later, this
        * field MUST be set and match the f|i|s|t|... field in use.  This
-       * change was made to accomodate proto3 implementations.
+       * change was made to accommodate proto3 implementations.
        * 
* * .onnx.AttributeProto.AttributeType type = 20; @@ -2930,10 +2930,10 @@ public final class OnnxMl { *
        * The type field MUST be present for this version of the IR.
        * For 0.0.1 versions of the IR, this field was not defined, and
-       * implementations needed to use has_field hueristics to determine
+       * implementations needed to use has_field heuristics to determine
        * which value field was in use.  For IR_VERSION 0.0.2 or later, this
        * field MUST be set and match the f|i|s|t|... field in use.  This
-       * change was made to accomodate proto3 implementations.
+       * change was made to accommodate proto3 implementations.
        * 
* * .onnx.AttributeProto.AttributeType type = 20; @@ -2951,10 +2951,10 @@ public final class OnnxMl { *
        * The type field MUST be present for this version of the IR.
        * For 0.0.1 versions of the IR, this field was not defined, and
-       * implementations needed to use has_field hueristics to determine
+       * implementations needed to use has_field heuristics to determine
        * which value field was in use.  For IR_VERSION 0.0.2 or later, this
        * field MUST be set and match the f|i|s|t|... field in use.  This
-       * change was made to accomodate proto3 implementations.
+       * change was made to accommodate proto3 implementations.
        * 
* * .onnx.AttributeProto.AttributeType type = 20; diff --git a/onnxruntime/core/providers/dml/DmlExecutionProvider/src/DmlCommandRecorder.cpp b/onnxruntime/core/providers/dml/DmlExecutionProvider/src/DmlCommandRecorder.cpp index 5d1bab8b67..9e8f7df9bf 100644 --- a/onnxruntime/core/providers/dml/DmlExecutionProvider/src/DmlCommandRecorder.cpp +++ b/onnxruntime/core/providers/dml/DmlExecutionProvider/src/DmlCommandRecorder.cpp @@ -266,7 +266,7 @@ void DmlCommandRecorder::ExecuteCommandList( m_currentDescriptorHeap = nullptr; Open(); - // The caller can re-use relevent resources after the next set of work to be + // The caller can re-use relevant resources after the next set of work to be // flushed has completed. Its command list hasn't been executed yet, just batched. GpuEvent gpuEvent = m_queue->GetNextCompletionEvent(); gpuEvent.fence.CopyTo(fence); diff --git a/server/test/integration_tests/README.MD b/server/test/integration_tests/README.MD index 291e44e67b..3319e5a61f 100644 --- a/server/test/integration_tests/README.MD +++ b/server/test/integration_tests/README.MD @@ -2,7 +2,7 @@ ## Preparation -Tests validation depends on protobuf generated *_pb2.py. So we need to have a sucessful server application build to have it generated in the build folder under `server_test` subfolder. The following instruction assume you are in the folder. Otherwise, tests will fail due to `ModuleNotFoundError`. +Tests validation depends on protobuf generated *_pb2.py. So we need to have a successful server application build to have it generated in the build folder under `server_test` subfolder. The following instruction assume you are in the folder. Otherwise, tests will fail due to `ModuleNotFoundError`. ## Functional Tests