saymrwulf/onnxruntime
1
0
Fork 0
mirror of https://github.com/saymrwulf/onnxruntime.git synced 2026-07-30 20:18:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix static analysis warning by making derived classes final. (#13123)

Browse source 
Follow up to #13059, which only updated the base classes. This change ensures that the derived classes will not be base classes.
This commit is contained in:
Edward Chen 2022-09-27 15:45:45 -07:00 committed by GitHub
parent e19163167e
commit 457a53c92f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
onnxruntime/core/framework/kernel_lookup.h
View file

@ -18,7 +18,7 @@ namespace onnxruntime {
* Utility class for performing kernel lookup.
* Primary usage pattern is to be created during graph partitioning and passed to IExecutionProvider::GetCapability().
*/
class KernelLookup : public IExecutionProvider::IKernelLookup {
class KernelLookup final : public IExecutionProvider::IKernelLookup {
public:
KernelLookup(ProviderType provider_type,
gsl::span<const gsl::not_null<const KernelRegistry*>> kernel_registries,

4
onnxruntime/core/framework/kernel_type_str_resolver.h
View file

@ -62,7 +62,7 @@ class IKernelTypeStrResolver {
* Supports loading information from op schemas in a full build and saving to/loading from an ORT format model
* representation.
*/
class KernelTypeStrResolver : public IKernelTypeStrResolver {
class KernelTypeStrResolver final : public IKernelTypeStrResolver {
public:
Status ResolveKernelTypeStr(const Node& node, std::string_view kernel_type_str,
gsl::span<const ArgTypeAndIndex>& resolved_args) const override;
@ -124,7 +124,7 @@ class KernelTypeStrResolver : public IKernelTypeStrResolver {
*
* As this requires node op schemas, it is only enabled in a full build.
*/
class OpSchemaKernelTypeStrResolver : public IKernelTypeStrResolver {
class OpSchemaKernelTypeStrResolver final : public IKernelTypeStrResolver {
public:
// Note: `node`'s op schema must be populated.
Status ResolveKernelTypeStr(const Node& node, std::string_view kernel_type_str,