saymrwulf/onnxruntime
1
0
Fork 0
mirror of https://github.com/saymrwulf/onnxruntime.git synced 2026-05-19 21:32:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Address static analysis warnings (#12711)

Browse source 
Address static analysis warnings
This commit is contained in:
Dmitri Smirnov 2022-08-26 14:24:14 -07:00 committed by GitHub
parent 34d90dd5bd
commit 3ff75fa05f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
onnxruntime/core/providers/cuda/rnn/cudnn_rnn_base.cc
View file

@ -292,7 +292,7 @@ Status CudnnRnnBase<T>::ComputeInternal(OpKernelContext* ctx) const {
zero_seq_index_cache_size = zero_seq_count * num_directions_;
zero_seq_index_cache.resize(zero_seq_index_cache_size);
for (int64_t i = 0; i < zero_seq_count; ++i) {
zero_seq_index_cache[zero_seq_count + i] = static_cast<int32_t>(batch_size + zero_seq_index_cache[i]);
zero_seq_index_cache[static_cast<size_t>(zero_seq_count) + i] = static_cast<int32_t>(batch_size + zero_seq_index_cache[i]);
}
}

4
onnxruntime/core/providers/cuda/tensor/where.cc
View file

@ -115,8 +115,8 @@ struct TernaryElementwisePreparation {
auto offset = out_rank - rank;
for (auto i = offset; i < out_rank; ++i) {
// the stride for broadcast dimension is kept as 0
if (shape.GetDims()[i - offset] != 1) {
padded_strides[i] = pitches[i - offset];
if (shape.GetDims()[gsl::narrow_cast<size_t>(i) - offset] != 1) {
padded_strides[i] = pitches[gsl::narrow_cast<size_t>(i) - offset];
}
}
}

12
onnxruntime/python/onnxruntime_pybind_mlvalue.cc
View file

@ -160,14 +160,18 @@ AllocatorPtr GetCudaAllocator(OrtDevice::DeviceId id) {
// Current approach is not thread-safe, but there are some bigger infra pieces to put together in order to make
// multi-threaded CUDA allocation work we need to maintain a per-thread CUDA allocator
static auto* id_to_allocator_map = new std::unordered_map<OrtDevice::DeviceId, AllocatorPtr>();
// We are leaking this map so we do not accidentally destroy CUDA Allocator instance
// after we unloaded CUDA provider library. Appeasing static analysis warning and using make_unique.
static auto* id_to_allocator_map = std::make_unique<std::unordered_map<OrtDevice::DeviceId, AllocatorPtr>>().release();
if (id_to_allocator_map->find(id) == id_to_allocator_map->end()) {
auto hit = id_to_allocator_map->find(id);
if (hit == id_to_allocator_map->end()) {
// TODO: Expose knobs so that users can set fields associated with OrtArenaCfg so that we can pass it to the following method
id_to_allocator_map->insert({id, GetProviderInfo_CUDA().CreateCudaAllocator(id, gpu_mem_limit, arena_extend_strategy, external_allocator_info, nullptr)});
auto cuda_allocator = GetProviderInfo_CUDA().CreateCudaAllocator(id, gpu_mem_limit, arena_extend_strategy, external_allocator_info, nullptr);
hit = id_to_allocator_map->emplace(id, std::move(cuda_allocator)).first;
}
return (*id_to_allocator_map)[id];
return hit->second;
}
std::unique_ptr<IDataTransfer> GetGPUDataTransfer() {