From 3e5dbfd94f30ee328f3fc6b305f37d10e44a1d85 Mon Sep 17 00:00:00 2001 From: Edward Chen <18449977+edgchen1@users.noreply.github.com> Date: Fri, 5 Nov 2021 09:41:20 -0700 Subject: [PATCH] Increase binary size limit and publish binary size data even if limit is exceeded. (#9675) --- .../linux-cpu-minimal-build-ci-pipeline.yml | 16 ++++++++++++---- ...l_ort_android_baseline_and_report_bin_size.sh | 2 +- 2 files changed, 13 insertions(+), 5 deletions(-) diff --git a/tools/ci_build/github/azure-pipelines/linux-cpu-minimal-build-ci-pipeline.yml b/tools/ci_build/github/azure-pipelines/linux-cpu-minimal-build-ci-pipeline.yml index 4a70d48f73..0d4d715db1 100644 --- a/tools/ci_build/github/azure-pipelines/linux-cpu-minimal-build-ci-pipeline.yml +++ b/tools/ci_build/github/azure-pipelines/linux-cpu-minimal-build-ci-pipeline.yml @@ -179,15 +179,23 @@ jobs: - task: AzureCLI@2 - displayName: 'Azure CLI' - condition: and (succeeded(), in(variables['Build.Reason'], 'IndividualCI', 'BatchedCI'), eq(variables['Build.SourceBranch'], 'refs/heads/master')) + displayName: 'Publish binary size data' + condition: and(succeededOrFailed(), in(variables['Build.Reason'], 'IndividualCI', 'BatchedCI'), eq(variables['Build.SourceBranch'], 'refs/heads/master')) inputs: azureSubscription: AIInfraBuild scriptLocation: inlineScript scriptType: bash inlineScript: | - /usr/bin/python3 $(Build.SourcesDirectory)/tools/ci_build/github/windows/post_binary_sizes_to_dashboard.py --commit_hash=$(Build.SourceVersion) \ - --size_data_file=$(Build.BinariesDirectory)/MinSizeRel/binary_size_data.txt --build_project=onnxruntime --build_id=$(Build.BuildId) + BINARY_SIZE_DATA_FILE="$(Build.BinariesDirectory)/MinSizeRel/binary_size_data.txt" + if [[ ! -f "${BINARY_SIZE_DATA_FILE}" ]]; then + echo "File not found: ${BINARY_SIZE_DATA_FILE}" + exit 1 + fi + /usr/bin/python3 $(Build.SourcesDirectory)/tools/ci_build/github/windows/post_binary_sizes_to_dashboard.py \ + --commit_hash=$(Build.SourceVersion) \ + --size_data_file="${BINARY_SIZE_DATA_FILE}" \ + --build_project=onnxruntime \ + --build_id=$(Build.BuildId) workingDirectory: '$(Build.BinariesDirectory)' - task: PublishTestResults@2 diff --git a/tools/ci_build/github/linux/ort_minimal/build_minimal_ort_android_baseline_and_report_bin_size.sh b/tools/ci_build/github/linux/ort_minimal/build_minimal_ort_android_baseline_and_report_bin_size.sh index de2d08d087..7b1ea8067b 100755 --- a/tools/ci_build/github/linux/ort_minimal/build_minimal_ort_android_baseline_and_report_bin_size.sh +++ b/tools/ci_build/github/linux/ort_minimal/build_minimal_ort_android_baseline_and_report_bin_size.sh @@ -29,7 +29,7 @@ python3 /onnxruntime_src/tools/ci_build/build.py \ --include_ops_by_config /home/onnxruntimedev/.test_data/include_no_operators.config # set current size limit to BINARY_SIZE_LIMIT_IN_BYTES. -BINARY_SIZE_LIMIT_IN_BYTES=1299000 +BINARY_SIZE_LIMIT_IN_BYTES=1302000 echo "The current preset binary size limit is $BINARY_SIZE_LIMIT_IN_BYTES" python3 /onnxruntime_src/tools/ci_build/github/linux/ort_minimal/check_build_binary_size.py \ --threshold=$BINARY_SIZE_LIMIT_IN_BYTES \