From 33ae28ccb18efd2804c165a40ed6370a1ab44b4d Mon Sep 17 00:00:00 2001 From: xkszltl Date: Fri, 26 Jul 2019 03:11:37 -0700 Subject: [PATCH] Empty double quota `""` is passed to `find_package(Thread)`, causing a test command `gcc ... "" ...` failed while trying to compile a source file with empty name. (#1508) ``` [user@******** /]# gcc "" gcc: error: : No such file or directory gcc: fatal error: no input files compilation terminated. ``` --- cmake/external/mkldnn.cmake | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmake/external/mkldnn.cmake b/cmake/external/mkldnn.cmake index 784f46b735..364ba88a89 100644 --- a/cmake/external/mkldnn.cmake +++ b/cmake/external/mkldnn.cmake @@ -62,9 +62,9 @@ if (onnxruntime_USE_MKLDNN) set (MKLDNN_CMAKE_EXTRA_ARGS) if(NOT onnxruntime_BUILD_FOR_NATIVE_MACHINE) # pre-v1.0 - list(APPEND MKLDNN_CMAKE_EXTRA_ARGS "-DARCH_OPT_FLAGS=\"\"") + list(APPEND MKLDNN_CMAKE_EXTRA_ARGS "-DARCH_OPT_FLAGS=") # v1.0 - list(APPEND MKLDNN_CMAKE_EXTRA_ARGS "-DMKLDNN_ARCH_OPT_FLAGS=\"\"") + list(APPEND MKLDNN_CMAKE_EXTRA_ARGS "-DMKLDNN_ARCH_OPT_FLAGS=") set(MKLDNN_PATCH_COMMAND1 git apply ${CMAKE_SOURCE_DIR}/patches/mkldnn/mem-patch.cmake.patch) # discard prior changes due to patching in mkldnn source to unblock incremental builds. set(MKLDNN_PATCH_DISCARD_COMMAND cd ${MKLDNN_SOURCE} && git checkout -- .)