saymrwulf/onnxruntime
1
0
Fork 0
mirror of https://github.com/saymrwulf/onnxruntime.git synced 2026-05-17 21:10:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Address PR comments and clean up. (#3536)

Browse source 
Address PR comments and clean up.
- https://github.com/microsoft/onnxruntime/pull/3174#discussion_r408549886
- https://github.com/microsoft/onnxruntime/pull/3174#discussion_r408551151
This commit is contained in:
edgchen1 2020-04-15 15:51:52 -07:00 committed by GitHub
parent 2536e80602
commit 2f16172e69
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
cmake/horovod/CMakeLists.txt
View file

@ -1,8 +1,5 @@
# Minimum CMake required
cmake_minimum_required(VERSION 3.11)
set(CMAKE_CXX_STANDARD 11)
# Copyright (c) Microsoft Corporation. All rights reserved.
# Licensed under the MIT License.
set(THIRD_PARTY_ROOT ${HOROVOD_ROOT}/third_party)

3
cmake/onnxruntime_unittests.cmake
View file

@ -29,11 +29,12 @@ function(AddTest)
add_executable(${_UT_TARGET} ${_UT_SOURCES})
source_group(TREE ${REPO_ROOT} FILES ${_UT_SOURCES})
if (MSVC AND NOT CMAKE_SIZEOF_VOID_P EQUAL 8)
#TODO: fix the warnings, they are dangerous
target_compile_options(${_UT_TARGET} PRIVATE "/wd4244")
endif()
#source_group(TREE ${TEST_SRC_DIR} FILES ${_UT_SOURCES})
set_target_properties(${_UT_TARGET} PROPERTIES FOLDER "ONNXRuntimeTest")
if (_UT_DEPENDS)

2
onnxruntime/core/protobuf/onnx-ml.proto
View file

@ -370,6 +370,7 @@ message ModelProto {
// Named metadata values; keys should be distinct.
repeated StringStringEntryProto metadata_props = 14;
// Training-specific information. Sequentially executing all stored
// `TrainingInfoProto.algorithm`s and assigning their outputs following
// the corresponding `TrainingInfoProto.update_binding`s is one training
@ -759,6 +760,7 @@ message FunctionProto {
repeated NodeProto node = 7;
// A human-readable documentation for this function. Markdown is allowed.
optional string doc_string = 8;
// The OperatorSets this function body (graph) relies on.
// A FunctionProto body (graph) may implicitly rely on the OperatorSet that
// this function belongs to. It can also explicitly rely on more OperatorSets

2
onnxruntime/core/protobuf/onnx-ml.proto3
View file

@ -370,6 +370,7 @@ message ModelProto {
// Named metadata values; keys should be distinct.
repeated StringStringEntryProto metadata_props = 14;
// Training-specific information. Sequentially executing all stored
// `TrainingInfoProto.algorithm`s and assigning their outputs following
// the corresponding `TrainingInfoProto.update_binding`s is one training
@ -763,6 +764,7 @@ message FunctionProto {
repeated NodeProto node = 7;
// A human-readable documentation for this function. Markdown is allowed.
string doc_string = 8;
// The OperatorSets this function body (graph) relies on.
// A FunctionProto body (graph) may implicitly rely on the OperatorSet that
// this function belongs to. It can also explicitly rely on more OperatorSets

2
onnxruntime/core/protobuf/onnx.in.proto
View file

@ -367,6 +367,7 @@ message ModelProto {
// Named metadata values; keys should be distinct.
repeated StringStringEntryProto metadata_props = 14;
// Training-specific information. Sequentially executing all stored
// `TrainingInfoProto.algorithm`s and assigning their outputs following
// the corresponding `TrainingInfoProto.update_binding`s is one training
@ -761,6 +762,7 @@ message FunctionProto {
repeated NodeProto node = 7;
// A human-readable documentation for this function. Markdown is allowed.
optional string doc_string = 8;
// The OperatorSets this function body (graph) relies on.
// A FunctionProto body (graph) may implicitly rely on the OperatorSet that
// this function belongs to. It can also explicitly rely on more OperatorSets