From 1d3b34cc923a58fd138e32a110acb16aa564cbb9 Mon Sep 17 00:00:00 2001 From: Tongliang Liao Date: Sat, 25 Dec 2021 23:10:56 +0800 Subject: [PATCH] Add `.git` suffix to github URL. Although github works with both, this is more precise. Having an extension also makes it easy to match with regex, when we want to inject code to reroute traffic to our own git mirror. --- .gitmodules | 8 ++++---- cmake/CMakeLists.txt | 2 +- cmake/external/dnnl.cmake | 2 +- cmake/external/zlib.cmake | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.gitmodules b/.gitmodules index b8ecf47269..3cb897233e 100644 --- a/.gitmodules +++ b/.gitmodules @@ -9,7 +9,7 @@ url = https://github.com/google/benchmark.git [submodule "cmake/external/onnx"] path = cmake/external/onnx - url = https://github.com/onnx/onnx + url = https://github.com/onnx/onnx.git [submodule "cmake/external/tvm"] path = cmake/external/tvm url = https://github.com/microsoft/onnxruntime-tvm.git @@ -18,7 +18,7 @@ url = https://github.com/HowardHinnant/date.git [submodule "cmake/external/nsync"] path = cmake/external/nsync - url = https://github.com/google/nsync + url = https://github.com/google/nsync.git [submodule "cmake/external/re2"] path = cmake/external/re2 url = https://github.com/google/re2.git @@ -39,10 +39,10 @@ url = https://github.com/NVlabs/cub.git [submodule "cmake/external/wil"] path = cmake/external/wil - url = https://github.com/microsoft/wil + url = https://github.com/microsoft/wil.git [submodule "cmake/external/json"] path = cmake/external/json - url = https://github.com/nlohmann/json + url = https://github.com/nlohmann/json.git [submodule "server/external/spdlog"] path = server/external/spdlog url = https://github.com/gabime/spdlog.git diff --git a/cmake/CMakeLists.txt b/cmake/CMakeLists.txt index 3c471ed49e..5328333e48 100644 --- a/cmake/CMakeLists.txt +++ b/cmake/CMakeLists.txt @@ -284,7 +284,7 @@ if (onnxruntime_BUILD_CSHARP) endif() if (NOT WIN32) - #TODO: On Linux we may try https://github.com/microsoft/TraceLogging + #TODO: On Linux we may try https://github.com/microsoft/TraceLogging.git if (onnxruntime_ENABLE_INSTRUMENT) message(WARNING "Instrument is only supported on Windows now") set(onnxruntime_ENABLE_INSTRUMENT OFF) diff --git a/cmake/external/dnnl.cmake b/cmake/external/dnnl.cmake index 953bcfaee7..6770e66a29 100644 --- a/cmake/external/dnnl.cmake +++ b/cmake/external/dnnl.cmake @@ -1,6 +1,6 @@ include (ExternalProject) -set(DNNL_URL https://github.com/oneapi-src/onednn) +set(DNNL_URL https://github.com/oneapi-src/onednn.git) # If DNNL_TAG is updated, check if MKLML_VERSION and platform.cmake.patch need to be updated. set(DNNL_TAG v2.4.4) diff --git a/cmake/external/zlib.cmake b/cmake/external/zlib.cmake index 0201417015..b7fcd22c7d 100644 --- a/cmake/external/zlib.cmake +++ b/cmake/external/zlib.cmake @@ -1,7 +1,7 @@ include (ExternalProject) set(zlib_INCLUDE_DIR ${CMAKE_CURRENT_BINARY_DIR}/external/zlib_archive) -set(ZLIB_URL https://github.com/madler/zlib) +set(ZLIB_URL https://github.com/madler/zlib.git) set(ZLIB_BUILD ${CMAKE_CURRENT_BINARY_DIR}/zlib/src/zlib) set(ZLIB_INSTALL ${CMAKE_CURRENT_BINARY_DIR}/zlib/install) set(ZLIB_TAG 50893291621658f355bc5b4d450a8d06a563053d)