saymrwulf/curve25519-dalek-source
1
0
Fork 0
mirror of https://github.com/saymrwulf/curve25519-dalek-source.git synced 2026-09-07 20:50:39 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Use ZeroizeOnDrop exclusively (#723)

Browse source
This commit is contained in:
Aaron Feickert 2025-01-19 10:55:45 -06:00 committed by GitHub
parent 868d614020
commit fbf1fb5339
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
x25519-dalek/src/x25519.rs
View file

@ -20,7 +20,7 @@ use rand_core::CryptoRng;
use rand_core::RngCore; use rand_core::RngCore;
#[cfg(feature = "zeroize")] #[cfg(feature = "zeroize")]
use zeroize::Zeroize; use zeroize::{Zeroize, ZeroizeOnDrop};
/// A Diffie-Hellman public key /// A Diffie-Hellman public key
/// ///
@ -70,8 +70,7 @@ impl AsRef<[u8]> for PublicKey {
/// are no serialization methods defined. This means that [`EphemeralSecret`]s can only be /// are no serialization methods defined. This means that [`EphemeralSecret`]s can only be
/// generated from fresh randomness where the compiler statically checks that the resulting /// generated from fresh randomness where the compiler statically checks that the resulting
/// secret is used at most once. /// secret is used at most once.
#[cfg_attr(feature = "zeroize", derive(Zeroize))] #[cfg_attr(feature = "zeroize", derive(Zeroize, ZeroizeOnDrop))]
#[cfg_attr(feature = "zeroize", zeroize(drop))]
pub struct EphemeralSecret(pub(crate) [u8; 32]); pub struct EphemeralSecret(pub(crate) [u8; 32]);
impl EphemeralSecret { impl EphemeralSecret {
@ -131,8 +130,7 @@ impl<'a> From<&'a EphemeralSecret> for PublicKey {
/// secret keys are never reused, which can have very serious security /// secret keys are never reused, which can have very serious security
/// implications for many protocols. /// implications for many protocols.
#[cfg(feature = "reusable_secrets")] #[cfg(feature = "reusable_secrets")]
#[cfg_attr(feature = "zeroize", derive(Zeroize))] #[cfg_attr(feature = "zeroize", derive(Zeroize, ZeroizeOnDrop))]
#[cfg_attr(feature = "zeroize", zeroize(drop))]
#[derive(Clone)] #[derive(Clone)]
pub struct ReusableSecret(pub(crate) [u8; 32]); pub struct ReusableSecret(pub(crate) [u8; 32]);
@ -192,8 +190,7 @@ impl<'a> From<&'a ReusableSecret> for PublicKey {
/// implications for many protocols. /// implications for many protocols.
#[cfg(feature = "static_secrets")] #[cfg(feature = "static_secrets")]
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
#[cfg_attr(feature = "zeroize", derive(Zeroize))] #[cfg_attr(feature = "zeroize", derive(Zeroize, ZeroizeOnDrop))]
#[cfg_attr(feature = "zeroize", zeroize(drop))]
#[derive(Clone)] #[derive(Clone)]
pub struct StaticSecret([u8; 32]); pub struct StaticSecret([u8; 32]);
@ -270,8 +267,7 @@ impl AsRef<[u8]> for StaticSecret {
/// ///
/// Each party computes this using their [`EphemeralSecret`] or [`StaticSecret`] and their /// Each party computes this using their [`EphemeralSecret`] or [`StaticSecret`] and their
/// counterparty's [`PublicKey`]. /// counterparty's [`PublicKey`].
#[cfg_attr(feature = "zeroize", derive(Zeroize))] #[cfg_attr(feature = "zeroize", derive(Zeroize, ZeroizeOnDrop))]
#[cfg_attr(feature = "zeroize", zeroize(drop))]
pub struct SharedSecret(pub(crate) MontgomeryPoint); pub struct SharedSecret(pub(crate) MontgomeryPoint);
impl SharedSecret { impl SharedSecret {