From b61ed818b87dc27f3021a46bd0890f832d690e9c Mon Sep 17 00:00:00 2001 From: Henry de Valence Date: Tue, 7 Mar 2017 01:32:11 -0800 Subject: [PATCH] Remove all remaining warnings --- src/constants.rs | 13 ------------- src/curve.rs | 4 ---- src/decaf.rs | 7 ++----- src/scalar.rs | 2 -- 4 files changed, 2 insertions(+), 24 deletions(-) diff --git a/src/constants.rs b/src/constants.rs index 6c4b53b..112d060 100644 --- a/src/constants.rs +++ b/src/constants.rs @@ -1574,19 +1574,12 @@ pub const base: [[AffineNielsPoint; 8]; 32] = [ #[cfg(test)] mod test { use field::FieldElement; - use curve::AffineNielsPoint; - use curve::CompressedEdwardsY; - use curve::ExtendedPoint; - use curve::Identity; use curve::IsIdentity; use curve::ValidityCheck; use constants; #[test] fn test_eight_torsion() { - let mut bytes = [0;32]; - bytes[0] = 1; - let compressed_id = CompressedEdwardsY(bytes); for i in 0..8 { let Q = constants::EIGHT_TORSION[i].mult_by_pow_2(3); assert!(Q.is_valid()); @@ -1596,9 +1589,6 @@ mod test { #[test] fn test_four_torsion() { - let mut bytes = [0;32]; - bytes[0] = 1; - let compressed_id = CompressedEdwardsY(bytes); for i in (0..8).filter(|i| i % 2 == 0) { let Q = constants::EIGHT_TORSION[i].mult_by_pow_2(2); assert!(Q.is_valid()); @@ -1608,9 +1598,6 @@ mod test { #[test] fn test_two_torsion() { - let mut bytes = [0;32]; - bytes[0] = 1; - let compressed_id = CompressedEdwardsY(bytes); for i in (0..8).filter(|i| i % 4 == 0) { let Q = constants::EIGHT_TORSION[i].mult_by_pow_2(1); assert!(Q.is_valid()); diff --git a/src/curve.rs b/src/curve.rs index c433767..e965078 100644 --- a/src/curve.rs +++ b/src/curve.rs @@ -80,7 +80,6 @@ use core::fmt::Debug; use core::iter::Iterator; use core::ops::{Add, Sub, Neg}; -use core::cmp::{PartialEq, Eq}; use constants; use field::FieldElement; @@ -1010,9 +1009,6 @@ impl Debug for ProjectiveNielsPoint { #[cfg(test)] mod test { - use test::Bencher; - use rand::OsRng; - use field::FieldElement; use scalar::Scalar; use subtle::CTAssignable; diff --git a/src/decaf.rs b/src/decaf.rs index aa2ded0..ec8e488 100644 --- a/src/decaf.rs +++ b/src/decaf.rs @@ -289,7 +289,6 @@ mod test { use scalar::Scalar; use constants; - use constants::BASE_CMPRSSD; use curve::CompressedEdwardsY; use curve::ExtendedPoint; use curve::BasepointMult; @@ -349,14 +348,12 @@ mod test { #[test] fn decaf_random_roundtrip() { let mut rng = OsRng::new().unwrap(); - for j in 0..100 { + for _ in 0..100 { let s = Scalar::random(&mut rng); let P = DecafPoint::basepoint_mult(&s); let compressed_P = P.compress(); let Q = compressed_P.decompress().unwrap(); - for i in 0..4 { - assert_eq!(P, Q); - } + assert_eq!(P, Q); } } } diff --git a/src/scalar.rs b/src/scalar.rs index 4aed3f4..0f70a19 100644 --- a/src/scalar.rs +++ b/src/scalar.rs @@ -37,7 +37,6 @@ use core::fmt::Debug; use rand::Rng; use digest::Digest; -use generic_array::GenericArray; use generic_array::typenum::U64; use constants; @@ -593,7 +592,6 @@ impl UnpackedScalar { #[cfg(test)] mod test { - use rand::Rng; use rand::OsRng; use super::*; use test::Bencher;