mirror of
https://github.com/saymrwulf/curve25519-dalek-source.git
synced 2026-09-08 21:00:40 +00:00
Remove fixme notes
This commit is contained in:
parent
628af18a1d
commit
4cbff3983d
2 changed files with 4 additions and 9 deletions
|
|
@ -37,14 +37,12 @@ use backend::avx2;
|
||||||
#[derive(Copy, Clone, Debug)]
|
#[derive(Copy, Clone, Debug)]
|
||||||
pub struct ExtendedPoint(pub(super) FieldElement32x4);
|
pub struct ExtendedPoint(pub(super) FieldElement32x4);
|
||||||
|
|
||||||
// XXX need to cfg gate here to handle FieldElement64
|
|
||||||
impl From<edwards::ExtendedPoint> for ExtendedPoint {
|
impl From<edwards::ExtendedPoint> for ExtendedPoint {
|
||||||
fn from(P: edwards::ExtendedPoint) -> ExtendedPoint {
|
fn from(P: edwards::ExtendedPoint) -> ExtendedPoint {
|
||||||
ExtendedPoint(FieldElement32x4::new(&P.X, &P.Y, &P.Z, &P.T))
|
ExtendedPoint(FieldElement32x4::new(&P.X, &P.Y, &P.Z, &P.T))
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// XXX need to cfg gate here to handle FieldElement64
|
|
||||||
impl From<ExtendedPoint> for edwards::ExtendedPoint {
|
impl From<ExtendedPoint> for edwards::ExtendedPoint {
|
||||||
fn from(P: ExtendedPoint) -> edwards::ExtendedPoint {
|
fn from(P: ExtendedPoint) -> edwards::ExtendedPoint {
|
||||||
let tmp = P.0.split();
|
let tmp = P.0.split();
|
||||||
|
|
@ -608,17 +606,15 @@ pub mod vartime {
|
||||||
Q.into()
|
Q.into()
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Given a vector of public scalars and a vector of (possibly secret)
|
/// Given a vector of public scalars and a vector of public points, compute
|
||||||
/// points, compute `c_1 P_1 + ... + c_n P_n`.
|
/// $$
|
||||||
|
/// Q = c\_1 P\_1 + \cdots + c\_n P\_n.
|
||||||
|
/// $$
|
||||||
///
|
///
|
||||||
/// # Input
|
/// # Input
|
||||||
///
|
///
|
||||||
/// A vector of `Scalar`s and a vector of `ExtendedPoints`. It is an
|
/// A vector of `Scalar`s and a vector of `ExtendedPoints`. It is an
|
||||||
/// error to call this function with two vectors of different lengths.
|
/// error to call this function with two vectors of different lengths.
|
||||||
///
|
|
||||||
/// XXX need to clear memory
|
|
||||||
///
|
|
||||||
/// XXX see note on consttime multiscalar mul
|
|
||||||
#[cfg(any(feature = "alloc", feature = "std"))]
|
#[cfg(any(feature = "alloc", feature = "std"))]
|
||||||
pub fn multiscalar_mult<'a, 'b, I, J>(scalars: I, points: J) -> edwards::ExtendedPoint
|
pub fn multiscalar_mult<'a, 'b, I, J>(scalars: I, points: J) -> edwards::ExtendedPoint
|
||||||
where I: IntoIterator<Item = &'a Scalar>,
|
where I: IntoIterator<Item = &'a Scalar>,
|
||||||
|
|
|
||||||
|
|
@ -120,7 +120,6 @@ impl FieldElement32x4 {
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Negate variables in lanes where mask is set
|
/// Negate variables in lanes where mask is set
|
||||||
/// XXX fix up api
|
|
||||||
pub fn negate(&mut self, mask: u8) {
|
pub fn negate(&mut self, mask: u8) {
|
||||||
let mask = mask as i32;
|
let mask = mask as i32;
|
||||||
unsafe {
|
unsafe {
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue