saymrwulf/curve25519-dalek-source
1
0
Fork 0
mirror of https://github.com/saymrwulf/curve25519-dalek-source.git synced 2026-09-06 20:41:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove clones on Copy types

Browse source
This commit is contained in:
Henry de Valence 2017-04-02 23:45:34 +02:00
parent 3705346afa
commit 162dfc8331
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/field.rs
View file

@ -132,7 +132,7 @@ impl<'b> AddAssign<&'b FieldElement> for FieldElement {
impl<'a, 'b> Add<&'b FieldElement> for &'a FieldElement { impl<'a, 'b> Add<&'b FieldElement> for &'a FieldElement {
type Output = FieldElement; type Output = FieldElement;
fn add(self, _rhs: &'b FieldElement) -> FieldElement { fn add(self, _rhs: &'b FieldElement) -> FieldElement {
let mut output = self.clone(); let mut output = *self;
output += _rhs; output += _rhs;
output output
} }
@ -158,7 +158,7 @@ impl<'a, 'b> Sub<&'b FieldElement> for &'a FieldElement {
type Output = FieldElement; type Output = FieldElement;
#[cfg(not(feature="radix_51"))] #[cfg(not(feature="radix_51"))]
fn sub(self, _rhs: &'b FieldElement) -> FieldElement { fn sub(self, _rhs: &'b FieldElement) -> FieldElement {
let mut output = self.clone(); let mut output = *self;
output -= _rhs; output -= _rhs;
output output
} }
@ -326,7 +326,7 @@ impl<'a, 'b> Mul<&'b FieldElement> for &'a FieldElement {
impl<'a> Neg for &'a FieldElement { impl<'a> Neg for &'a FieldElement {
type Output = FieldElement; type Output = FieldElement;
fn neg(self) -> FieldElement { fn neg(self) -> FieldElement {
let mut output = self.clone(); let mut output = *self;
output.negate(); output.negate();
output output
} }
@ -656,7 +656,7 @@ impl FieldElement {
// so floor(2^-255 * (h + 19 * 2^-25 * h9 + 2^-1)) = q. // so floor(2^-255 * (h + 19 * 2^-25 * h9 + 2^-1)) = q.
// //
let mut carry = [0i32; 10]; let mut carry = [0i32; 10];
let mut h = self.clone(); let mut h: [i32; 10] = self.0;
let mut q:i32 = (19*h[9] + (1 << 24)) >> 25; let mut q:i32 = (19*h[9] + (1 << 24)) >> 25;
q = (h[0] + q) >> 26; q = (h[0] + q) >> 26;
@ -1352,7 +1352,7 @@ mod test {
#[test] #[test]
fn from_bytes_highbit_is_ignored() { fn from_bytes_highbit_is_ignored() {
let mut cleared_bytes = B_BYTES.clone(); let mut cleared_bytes = B_BYTES;
cleared_bytes[31] &= 127u8; cleared_bytes[31] &= 127u8;
let with_highbit_set = FieldElement::from_bytes(&B_BYTES); let with_highbit_set = FieldElement::from_bytes(&B_BYTES);
let without_highbit_set = FieldElement::from_bytes(&cleared_bytes); let without_highbit_set = FieldElement::from_bytes(&cleared_bytes);