saymrwulf/cryptography
1
0
Fork 0
mirror of https://github.com/saymrwulf/cryptography.git synced 2026-05-14 20:37:55 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Order the elements in reviewing patches reasonably (#4883)

Browse source
This commit is contained in:
Alex Gaynor 2019-05-09 19:11:21 -04:00 committed by Paul Kehrer
parent fccbfc0fb9
commit ea4d1ee3fa
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
docs/development/reviewing-patches.rst
View file

@ -7,18 +7,18 @@ review is our opportunity to share knowledge, design ideas and make friends.
When reviewing a patch try to keep each of these concepts in mind:
Architecture
------------
* Is the proposed change being made in the correct place? Is it a fix in a
backend when it should be in the primitives?
Intent
------
* What is the change being proposed?
* Do we want this feature or is the bug they're fixing really a bug?
Architecture
------------
* Is the proposed change being made in the correct place? Is it a fix in a
backend when it should be in the primitives?
Implementation
--------------