From 18a7dc87be13c49fd118318e6fbd2e8b8896683c Mon Sep 17 00:00:00 2001 From: saymrwulf Date: Thu, 16 Apr 2026 10:27:18 +0200 Subject: [PATCH] Remove pre-commit hooks, focus on local validation via app.sh All quality checks (ruff, mypy, tests) run through app.sh validate. No external CI or hook infrastructure needed. --- .pre-commit-config.yaml | 34 ---------------------------------- README.md | 11 +++-------- THE_STORY.md | 2 -- pyproject.toml | 1 - 4 files changed, 3 insertions(+), 45 deletions(-) delete mode 100644 .pre-commit-config.yaml diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml deleted file mode 100644 index 5ab7458..0000000 --- a/.pre-commit-config.yaml +++ /dev/null @@ -1,34 +0,0 @@ -repos: - - repo: https://github.com/astral-sh/ruff-pre-commit - rev: v0.11.12 - hooks: - - id: ruff - args: [--fix, --exit-non-zero-on-fix] - - id: ruff-format - - - repo: https://github.com/pre-commit/mirrors-mypy - rev: v1.15.0 - hooks: - - id: mypy - additional_dependencies: - - types-PyYAML - args: [--config-file=pyproject.toml] - pass_filenames: false - entry: mypy src/autoresearch_quantum/ - - - repo: https://github.com/kynan/nbstripout - rev: 0.8.1 - hooks: - - id: nbstripout - args: [--extra-keys, "metadata.kernelspec metadata.language_info"] - - - repo: https://github.com/pre-commit/pre-commit-hooks - rev: v5.0.0 - hooks: - - id: trailing-whitespace - - id: end-of-file-fixer - exclude: '\.ipynb$' - - id: check-yaml - - id: check-added-large-files - args: [--maxkb=500] - - id: check-merge-conflict diff --git a/README.md b/README.md index 0a63e58..665534b 100644 --- a/README.md +++ b/README.md @@ -89,7 +89,6 @@ autoresearch-quantum/ │ ├── test_persistence.py JSON store round-trips │ ├── test_scoring.py Score function correctness │ └── test_teaching.py Assessment widget & tracker tests -├── .pre-commit-config.yaml Ruff, mypy, nbstripout, hygiene hooks ├── THE_STORY.md Narrative documentation (system design) ├── pyproject.toml Build config, dependencies, tool settings └── README.md @@ -400,15 +399,11 @@ pip install playwright && python -m playwright install chromium ### Static analysis +`app.sh validate` runs all three automatically: + - **Ruff** --- linting and formatting (E, F, W, I, UP, B, SIM rule sets) - **mypy** --- strict mode type checking across all source files -- **nbstripout** --- strips notebook outputs before commit - -All three run automatically as **pre-commit hooks** (`.pre-commit-config.yaml`). Install with: - -```bash -.venv/bin/pre-commit install -``` +- **nbstripout** --- strips notebook outputs (run manually: `.venv/bin/nbstripout notebooks/**/*.ipynb`) ## Extending The Ladder diff --git a/THE_STORY.md b/THE_STORY.md index a3c4503..7ffa551 100644 --- a/THE_STORY.md +++ b/THE_STORY.md @@ -629,8 +629,6 @@ autoresearch-quantum/ test_scoring.py Score functions test_teaching.py Assessment widgets & tracker - .pre-commit-config.yaml Ruff, mypy, nbstripout, hygiene hooks - data/ Output directory (created at runtime) default/ rung_1/ diff --git a/pyproject.toml b/pyproject.toml index 2177bed..e99d028 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -34,7 +34,6 @@ dev = [ "nbclient>=0.10,<1", "nbformat>=5,<6", "mypy>=1.15,<2", - "pre-commit>=4,<5", ] ux = [ "playwright>=1.52,<2",